Skip to content

ci: the init section talks to its own stack when isolated #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennywillbe merged 1 commit into from
Aug 31, 2026
Merged

ci: the init section talks to its own stack when isolated #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions dev/e2e-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,8 +992,12 @@ echo -e "\n\033[1m== 19. init writes a config that runs ==\033[0m"
# other one takes a `-c FILE` that has to exist first. Measured before this
# existed, the first hand-written config failed on an unqualified table name.
#
# Nothing is edited after `init` here, deliberately: the out-of-the-box path is
# what is being tested, down to the default config name and target url.
# The out-of-the-box path is what is being tested, down to the default config
# name and target url — the default is asserted below rather than passed to
# `init`. The one edit is the one an operator makes first, pointing the target
# at their own cluster: without it a run with a stack of its own (ci-local
# --isolated) would validate against whatever listens on the default port,
# which is the dev stack and not this run.
ABIN="$(pwd)/$BIN"
INITDIR=$(mktemp -d /tmp/pg2osync-e2e-init.XXXXXX)
pg "DROP TABLE IF EXISTS init_probe, init_no_pk;" > /dev/null 2>&1
Expand Down Expand Up @@ -1030,9 +1034,13 @@ if (cd "$INITDIR" && "$ABIN" init --table init_probe > /dev/null 2>&1); then
else
ok "init refuses to overwrite without --force"
fi
# The whole point: what it writes validates, unedited and with no -c flag.
check "and wrote the default target url" \
"$(grep -c '^url = "http://localhost:9200"$' "$INITDIR/pg2osync.toml" 2> /dev/null || echo 0)" "1"
sed "s|^url = \"http://localhost:9200\"$|url = \"$OS\"|" "$INITDIR/pg2osync.toml" \
> "$INITDIR/retargeted.toml" && mv "$INITDIR/retargeted.toml" "$INITDIR/pg2osync.toml"
# The whole point: what it writes validates, with no -c flag.
if (cd "$INITDIR" && "$ABIN" validate > /dev/null 2>&1); then
ok "validate passes on the generated config, unedited"
ok "validate passes on the generated config"
else
bad "the generated config does not validate"
fi
Expand Down