Repository navigation
fix: keep the session menu in front after installing ControlFS - #137
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes The review covers the ControlFS install-completion behavior, its localized row state, and the associated manual test and beta release metadata.
- Install completion The menu remains open after installation, shows an installed state, and leaves launching ControlFS to the next A press.
- Localization and manual test The new row text is added to all three catalogs, and the testing checklist reflects the new flow, including closing the menu during installation.
- Beta release metadata Both changelogs and the project version are updated to
1.6.0-beta.6.
gpt-6-luna | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Follow-up to #136. After installing ControlFS from the session menu, the app no longer opens it by itself.
Before, the end of the install called
OpenControlFs(), which closed the menu and launched ControlFS. By then Windows didn't hand ControlFS the foreground, so in a Big Picture session the menu disappeared and ControlFS came up behind Big Picture (reported on 1.6.0-beta.5; the log showsControlFS: instaladofollowed immediately byControlFS: aberto).Now the menu stays open and in front, the row says "Installed · press to open" (new
ControlFsInstalledstring in the three catalogs), and the next A opens ControlFS the usual way. The row goes back to its normal text the next time the menu opens.Verification
docs/TESTING.md(1d).🤖 Generated with Claude Code