Repository navigation
Conversation
davidliu
requested review from
1egoman,
lukasIO and
xianshijing-lk
as code owners
October 21, 2026 09:43
🦋 Changeset detectedLatest commit: 9cacb05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Contributor
size-limit report 📦
|
lukasIO
approved these changes
Oct 21, 2026
1egoman
approved these changes
Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On React Native, messages still get received and emitted even after close (See react/react-native#59289). Web drops messages after close automatically, so it's a non issue there.
The issue this behavior surfaces is that a full reconnect that starts while the signal connection is still open gets cancelled, and the room disconnects instead of reconnecting.
restartConnectionsends a leave on the open signal connection.cleanupClientthen closes the socket and waits up to 250ms for it to close before callingresetCallbacks().LeaveRequest(action: DISCONNECT,reason: CLIENT_INITIATED), which arrives during that window.readyStateisn'tOPEN, so on web the reply never reaches the read loop. React Native'sWebSocketdispatches them anyway.onLeave, which emitsDisconnectedand closes the engine, cancelling the restart.Fix
WebSocketStreamnow enqueues messages only whilews.readyState === WebSocket.OPEN, matching browser behaviour. Nothing changes on web, where these messages were never delivered.