Skip to content

Ignore signal messages received after the WebSocket is closed on RN #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidliu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore signal messages received after the WebSocket is closed on RN #2173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/short-toys-push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'livekit-client': patch
---

Ignore signal messages received after the WebSocket is closed on React Native
7 changes: 6 additions & 1 deletion src/api/WebSocketStream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,12 @@ export class WebSocketStream<T extends ArrayBuffer | string = ArrayBuffer | stri
resolve({
readable: new ReadableStream<T>({
start(controller) {
ws.onmessage = ({ data }) => controller.enqueue(data);
ws.onmessage = ({ data }) => {
// workaround for RN behavior, browsers drop these messages already
if (ws.readyState === WebSocket.OPEN) {
controller.enqueue(data);
}
};
ws.onerror = (e) =>
controller.error(ConnectionError.websocket(getErrorDescription(e, 'websocket')));
ws.onclose = (ev) => {
Expand Down
Loading