Repository navigation
feat(room): report room SID changes with OnRoomSIDChanged - #1038
Closed
biglittlebigben wants to merge 1 commit into
Closed
biglittlebigben wants to merge 1 commit into
biglittlebigben wants to merge 1 commit into
Conversation
setSid replaces a known SID with a different non-empty one; OnRoomUpdate calls the new RoomCallback.OnRoomSIDChanged when it does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Room.SID()follows the room's current session: a room update carrying a different non-empty SID replaces the known one.RoomCallback.OnRoomSIDChanged(roomSID), called when the SID changes after it was first known — the server starting a new session for a live room, a full reconnect into a new session, or a move.OnRoomMovedsets the destination room name before applying the SID, soOnRoomSIDChangedobserves the new name.Testing
TestOnRoomUpdateReportsSIDChangeandTestOnRoomMovedReportsSIDChangeWithNewName;go test -race -run TestOnRoom .passes.🤖 Generated with Claude Code