Repository navigation
fix(react-native): remove invalid config plugin reference in app.json and README - #588
Open
Reginald Alfret V (reginaldalfret) wants to merge 1 commit into
Conversation
… and README (fixes microsoft#548) Signed-off-by: Reginald Alfret <reginaldalfret@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #548.
Description
The package
onnxruntime-react-nativeis a native React Native module that is linked automatically via standard React Native autolinking duringexpo prebuild. It is not an Expo config plugin. Having"plugins": ["onnxruntime-react-native"]inapp.jsoncausednpx expo prebuildandnpx expo installto fail with:CommandError: Package "onnxruntime-react-native" does not contain a valid config plugin.Changes
mobile/examples/React_Native/ort-rn-basic-usage/app.json: Removed the invalid"plugins": ["onnxruntime-react-native"]entry.mobile/examples/React_Native/ort-rn-basic-usage/README.md: Updated Step 3 to explain thatonnxruntime-react-nativeis linked automatically via React Native autolinking duringexpo prebuild, and removed the instruction to add the plugin entry inapp.json.