Skip to content

fix(react-native): remove invalid config plugin reference in app.json and README #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Reginald Alfret V (reginaldalfret) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(react-native): remove invalid config plugin reference in app.json and README #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions mobile/examples/React_Native/ort-rn-basic-usage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,9 @@ The following steps were done in this sample for using onxnruntime-react-native.

3. Generate Android and iOS directories native code to run your React Native app.

In this sample project, it generates the native code automatically by using package `onnxruntime-react-native` as an Expo plugin. (Recommended approach.)

- In `<PROJECT_ROOT>/app.json`, add the following line to section `expo`:
```
"plugins": ["onnxruntime-react-native"],
```
Note: The plugin is added by default in `app.json` in the sample.
`onnxruntime-react-native` is linked automatically via React Native autolinking during `expo prebuild`. It is a native React Native module, not an Expo config plugin, so no plugin entry is required in `app.json`.

- Run the following command in `<PROJECT_ROOT>` to generate Android and iOS project: More info about [Expo CLI Prebuild](https://docs.expo.dev/workflow/prebuild/).
- Run the following command in `<PROJECT_ROOT>` to generate the Android and iOS project: More info about [Expo CLI Prebuild](https://docs.expo.dev/workflow/prebuild/).
```sh
expo prebuild
```
Expand Down
1 change: 0 additions & 1 deletion mobile/examples/React_Native/ort-rn-basic-usage/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"expo": {
"name": "OrtReactNativeBasicUsage",
"slug": "OrtReactNativeBasicUsage",
"plugins": ["onnxruntime-react-native"],
"version": "1.0.0",
"orientation": "portrait",
"icon": "./assets/icon.png",
Expand Down
Loading