Conversation
kapunakap
requested review from
Waldz,
redhatua,
redmundas and
soffokl
as code owners
September 21, 2026 14:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
HermesPromiseHandler.RequestPromisereports failures by sending an error on its result channel and reports success by closing that channel without sending a value.InvoiceTracker.handlePromiseErrorscurrently forwards only values received from that channel. As a result, a successful promise request never reacheshandleHermesError(nil), sohermesFailureCountis not reset after success. Retryable Hermes failures can therefore accumulate across successful promise requests even though the configured limit is intended to cover failures "in a row".This change treats a clean result-channel close as a successful completion and forwards
nilto the existing Hermes error handler. If the channel emitted any result, closing it does not synthesize an additional success result.The forwarding is also stop-aware so a late result cannot block the helper after the invoice tracker has stopped.
Tests
Added regression coverage that verifies:
Related to #6218. This is a narrow payment-engine correctness fix; it does not claim to resolve all connection churn described there.