Repository navigation
[docs]: add example data for compatible models - #427
Schiano-NOAA wants to merge 5 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| repository: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name || github.repository }} | ||
| ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || github.ref_name }} | ||
|
|
||
| - uses: r-lib/actions/setup-r@v2 |
| with: | ||
| use-public-rspm: true | ||
|
|
||
| - uses: r-lib/actions/setup-r-dependencies@v2 |
Code Metrics Report
Reported by octocov |
| remotes::install_github("afsc-assessments/Rceattle") | ||
| # library(Rceattle) | ||
| # library(readxl) | ||
| Rceattle::data("GOApollock") |
There was a problem hiding this comment.
I get this error when running locally:
Error: 'data' is not an exported object from 'namespace:Rceattle'
There was a problem hiding this comment.
Hmm I will test again because idk what it could be from if not.
| @@ -0,0 +1,13 @@ | |||
| ## code to prepare `ss3_simple` dataset goes here | |||
There was a problem hiding this comment.
This works fine but I think the documentation (and filename) should be edited to clarify that this isn't converting raw SS3 output-- instead, SS3 output that's been formatted into a list by r4ss. Filename could be updated to something like "DATASET_SS3-r4ss.R", esp. if we're planning to retain the original "DATASET.R" file, which is also based on SS3 output
There was a problem hiding this comment.
Second question: are we retaining "DATASET.R"? I suppose we should, until SS3 output conversion is offically deprecated
There was a problem hiding this comment.
Yep right on the nose
There was a problem hiding this comment.
This adds >10 MB to the package. Can we reduce its size? Or will its size not impact package loading?
There was a problem hiding this comment.
I am currently looking into different approaches. I also need to add documentation for each dataset as an md file
sbreitbart-NOAA
left a comment
sbreitbart-NOAA
left a comment
There was a problem hiding this comment.
A few things to discuss and adjust before merging. Thanks for getting this started- it'll definitely make the package stronger!
8bdc4ca to
37c5cec
Compare
This branch has not been deployed
3 participants
Adding example data for each model compatible with
convert_output()