Repository navigation
Embed: AUTO checkbox, lanes down to the seek bar, and Load before downloading on a phone - #875
Merged
Merged
Conversation
…?mode= be-music-preview-select and be-music-preview-start gain an autoPlay property that shows an AUTO checkbox (the list's header, under the play button) and emits auto-play-change. The embed starts it from ?mode= and switches its mode on a change; under the play button it loads the play again in the other mode.
…r it On a phone held upright the lanes stopped well above the controls, and on a phone held sideways (SP or DP) the judgement line sat under the seek bar. Keep clear only the controls' 54 CSS px as tall as they get on a 320 px phone and a 16 px gap (previewJudgementInset), in both orientations. The preview HUD puts the controls along the bottom of the screen rather than the stage, so a DP chart letterboxed on a phone held upright keeps them off its lanes.
… on a phone A phone or tablet (or a browser asking to save data) no longer downloads the track as soon as the embed opens. It shows a Load button (be-music-preview-start's new load mode and caption) with the file name and the size a HEAD request reports; /__url-load-proxy now answers HEAD with the upstream's Content-Length.
Contributor
Exports Benchmark🔴 3 regressions · 0 improvements · 19 within noise · 888 compared
Regressions (3)
Changed packages
All 9 cases
New exports (1)
Within noise (19): past the threshold, but the runs overlap
…and 7 more. I/O-bound, not judged (19)These cases touch the filesystem, so their time follows the OS cache and the disk more than the code.
Excluded: too fast to time (74)A timed sample lasted 1 µs or less on at least one side (usually a base commit from before calls were batched), so its time is timer noise and no change is shown.
…and 62 more. Run details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
be-music-preview-select(list header) andbe-music-preview-start(under the play button) gainautoPlayand emitauto-play-change. The embed starts it from?mode=and switches between the AUTO preview and the viewer's play without touching the URL; under the play button it loads the play again in the other mode.previewJudgementInsetkeeps clear only the controls' 54 CSS px as tall as they get on a 320 px phone plus 16 px, in both orientations, and the preview HUD puts the controls along the bottom of the screen rather than the stage./__url-load-proxyanswers HEAD with the upstream'sContent-Length(unless compressed).@be-music/app-play,@be-music/player-uiand@be-music/worker-play, and the bench case for the new export.Tests
pnpm run checkvp test run packages/player-ui packages/app-play/src/embed packages/worker-play(new:embedModeOfAutoPlay,embedWaitsToDownload,readDownloadSize/describeDownload,previewJudgementInset, the proxy's HEAD size)🤖 Generated with Claude Code