fix(decorations): fix decorations.device returning always nil - #536
Merged
sidlatau merged 1 commit intoSep 25, 2026
Merged
Conversation
sidlatau
approved these changes
Sep 25, 2026
Collaborator
|
Thanks, @NorinB ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed, that the flutter-tools' device decoration never returned a device name.
I fixed that by adding device resolution even before the first
flutter runis dispatched. In that case the device is picked, that flutter would use, if flutter run is invoked without picking a device via the-dflag. IfFlutterRun,FlutterDevicesorFlutterEmulatorsis used to run the Flutter app, the decorations value is updated with the device, that the app is actually running on.