Take core 7.4.0, and format sheet cells and align paragraphs - #697
Merged
Merged
Conversation
Core 7.4.0 formats a selection of cells in the sheet editor and aligns paragraphs in odt, odp, odg, docx and pptx. The strip now shows over a sheet, with a fill in place of the highlight. Both strips get an alignment tool. The fill is the free tool of a sheet in lite, as the highlighter is in a document. HtmlConfig.hostMessageHandler sends every odr.on* callback to PageView.postMessage, so editing-bridge.js and its injection are gone. HtmlConfig.sheetEditOnClick and pdfAnnotationMarkOnSelection replace the two calls that the script made after each page load. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTmf15E1oFAe5PrtjT2Cz8
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR takes core v7.4.0 and uses its new features.
justify. The icon shows the alignment of the selection.HtmlConfig.hostMessageHandler. The page sends everyodr.on*callback toPageView.postMessage. This PR deletesediting-bridge.jsand its injection inonPageFinished. The callbacks are now in place before the page's scripts run, not after the load finishes.HtmlConfig.sheetEditOnClickandpdfAnnotationMarkOnSelection. These replace the two calls that the injected script made after each load.Changes in the core that come with the version and need no work in the app:
PageView.shouldOverrideUrlLoadingalready gives such a link to another app. I keepallowExternalContentoff, because no document leaves the device.Not used:
PdfFile.permissionsandpdfEnforcePermissions. pdf.js keeps them off by default too. Enforcing them would block copy and print on some pdfs. That is a product decision, so I did not make it here.The new strings are in English only. Run
scripts/translate-app.pybefore the release.Test plan
spotlessCheck assembleDebug lintProDebug testProDebugUnitTestconnectedProDebugAndroidTest: 98 of 98 pass on Pixel_6_Pro (API 31)connectedLiteDebugAndroidTest: 98 of 98 pass on Pixel_6_Pro (API 31)aSheetCellTakesAFillpins a cell and taps the fill. It checks that the page logs asetCellStyleop, and that the edit reaches the app throughpostMessage.🤖 Generated with Claude Code