Cut 4.21.0, and keep the editions out of the store notes - #700
Merged
Merged
Conversation
The release run refused v4.21.0, because CHANGELOG.md had no 4.21.0 section. A pull request cuts the heading before a release, as #682 did for 4.20.1. The head of the changelog said the release run cuts it, so that line now says what the check does. The store notes said that the fill is free in every edition. The same notes go to lite and to pro, which is what #682 took out of the notes of 4.20.0. That sentence is gone in all 15 locales, and from the changelog entry. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTmf15E1oFAe5PrtjT2Cz8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release run for v4.21.0 stopped at "check the changelog names this version" (run 37127836677). It built nothing and uploaded nothing.
CHANGELOG.mdhad no## 4.21.0section. A PR cuts the heading before a release, as Cut 4.20.1 and write what the store says about it #682 did for 4.20.1. The head of the changelog said that the release run cuts it, which is wrong, so that line now describes what the check does.Test plan
.github/scripts/changelog-section.py --version v4.21.0prints the sectionscripts/store-listing.py --version v4.21.0: store copy in all 15 locales, the longest is 408 charactersAfter the merge, run
gh workflow run release.yml -f version=v4.21.0again.🤖 Generated with Claude Code