feat: add support contact tag pipeline step - #2688
Merged
Merged
Conversation
This was referenced Sep 3, 2026
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2688 +/- ##
=======================================
Coverage 87.02% 87.03%
=======================================
Files 263 264 +1
Lines 17234 17247 +13
Branches 1704 1705 +1
=======================================
+ Hits 14998 15011 +13
Misses 1897 1897
Partials 339 339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 8, 2026 12:37
baa85bf to
99ba6af
Compare
brobro10000
changed the title
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 8, 2026 14:03
99ba6af to
3b8d8a8
Compare
pwnage101
reviewed
Sep 8, 2026
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 8, 2026 16:41
3b8d8a8 to
a626b13
Compare
pwnage101
reviewed
Sep 8, 2026
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 9, 2026 16:09
a626b13 to
959e503
Compare
Adds SupportContactEnterpriseTagStep, registered in ENTERPRISE_FILTERS_CONFIG against the new SupportContactContextRequested openedx-filter. Per pwnage101's review feedback, the current request is fetched internally via crum.get_current_request() rather than threaded through the filter/pipeline signature (matching courseware.py, dashboard.py, enrollment.py, logistration.py, course_modes.py). Also per review feedback, doesn't add a defensive None-check around the guarded enterprise_support import — the top-level try/except ImportError guard is sufficient, matching discounts.py/courseware.py, and the extra check would just need to be removed again once ENT-11576 drops the guarded import entirely. Follows the established pattern used by the other edx-enterprise filter pipeline steps: top-level imports guarded by try/except ImportError, no broad exception swallowing, and tests built on real Django model factories. ENT-11574
brobro10000
force-pushed
the
brobro10000/ENT-11574
branch
from
September 9, 2026 16:36
959e503 to
d6e4b37
Compare
brobro10000
marked this pull request as ready for review
September 9, 2026 18:02
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENT-11574
Adds
SupportContactEnterpriseTagStep, registered inENTERPRISE_FILTERS_CONFIG(
enterprise/settings/common.py) against the newSupportContactContextRequestedopenedx-filter. Appends the
enterprise_learnertag to support tickets submitted byrequesters linked to a customer account — the same check and tag value as the original
inline
contact_us.pylogic, just moved behind a filter.Follows the pattern established by the other edx-enterprise filter pipeline steps
(
discounts.py,courseware.py,enrollment.py): top-level imports guarded bytry/except ImportError, no broad exception swallowing,fail_silently: False(matchingevery current
ENTERPRISE_FILTERS_CONFIGentry — errors propagate rather than beingswallowed), and tests built on real Django model factories rather than module-mocking.
Registration lives in
enterprise/settings/common.py'splugin_settings(), not inopenedx-platform/edx-platformsettings — per theENT-11830ownership handoff (alreadymerged in all 3 repos before this branch existed).
Related PRs
Testing
New:
tests/filters/test_support.py— 4 tests forSupportContactEnterpriseTagStep, using areal
UserFactoryinstance andRequestFactory. The existing genericTestEnterpriseFiltersConfigsmoke test intests/test_enterprise/test_settings.pyalsocovers our new
ENTERPRISE_FILTERS_CONFIGentry automatically (no changes needed there).Locally verified:
pytest tests/filters/ tests/test_enterprise/test_settings.py— 80 passed.isort --check-onlyclean.Changelog / version
Bumped
__version__to8.10.0and added aCHANGELOG.rstentry, matching current practice(e.g. #2556).
Devstack testing (all 3 relevant branches checked out together) is required before merging,
per the enterprise plugin ticket runbook — see handoff prompt in the openedx-platform PR.