chore: Unbreak the clippy and link-check jobs - #562
Merged
Merged
Conversation
…nsion The lint (new in clippy 1.81) fires inside the #[pallet::pallet] macro expansion, which this crate does not control; under #![deny(warnings)] it has failed every clippy run since the toolchain bump.
GitHub rate-limits the checker on that blob URL (HTTP 429), failing the job on every PR for a link that is not dead.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Narrow the link-check ignore pattern to avoid skipping validation for the entire repository.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR unblocks Clippy and Markdown link-check CI jobs.
Changes:
- Allows the generated
clippy::manual_inspectwarning. - Adds a link-check exception for the archived documentation URL.
File summaries
| File | Summary |
|---|---|
pallets/orml-currencies-allowance-extension/src/lib.rs |
Suppresses the macro-generated Clippy warning. |
.github/workflows/mlc_config.json |
Adds the link-check ignore pattern; it should be narrowed to the single archived URL. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
`manual_inspect` (clippy 1.81) fires inside the `#[pallet::pallet]` expansion of our polkadot-sdk fork. Three pallets carry `deny(warnings)`, so allowing it per crate would need three copies; a CLI `-A` overrides the crate-level deny for all of them at once. Drops the per-crate allow again.
No runtime declares an `experimental` feature, so the cfg-gated `SlotDuration` line was always compiled out. Rust 1.81's `unexpected_cfgs` now rejects it under `-Dwarnings`, which broke the test-code job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pre-existing CI failures unrelated to the migration work:
clippy::manual_inspect(clippy 1.81) fires inside the#[pallet::pallet]macro expansion oforml-currencies-allowance-extension; with that crate's#![deny(warnings)]every clippy run has failed since the toolchain bump. Allowed at crate level; verified withRUSTFLAGS=-Dwarnings cargo clippy --release -p orml-currencies-allowance-extension.