Skip to content

chore: Unbreak the clippy and link-check jobs #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebma merged 5 commits into from
Sep 16, 2026
Merged

chore: Unbreak the clippy and link-check jobs #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c8c11e
chore: Allow clippy::manual_inspect in orml-currencies-allowance-exte…
ebma Sep 14, 2026
385204c
ci: Ignore the archived substrate-docs link in the markdown link check
ebma Sep 14, 2026
feb397b
Potential fix for pull request finding
ebma Sep 15, 2026
5095768
ci: Allow clippy::manual_inspect once, on the clippy command line
ebma Sep 16, 2026
047d38f
chore: Remove the dead `experimental` cfg from the runtimes
ebma Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/clippy-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ jobs:
uses: actions-rs/cargo@v1
with:
command: clippy
args: --release --all-features -- -W clippy::all -A clippy::style -A forgetting_copy_types -A forgetting_references
# `manual_inspect` (clippy 1.81) fires inside the `#[pallet::pallet]` expansion of our
# polkadot-sdk fork; the `deny(warnings)` pallets cannot allow it from the outside.
args: --release --all-features -- -W clippy::all -A clippy::style -A clippy::manual_inspect -A forgetting_copy_types -A forgetting_references

- name: Clippy -- All Targets (except integration)
uses: actions-rs/cargo@v1
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/mlc_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"ignorePatterns": [
{
"pattern": "^https://crates.io"
},
{
"pattern": "^https://github.com/substrate-developer-hub/substrate-docs/blob/314e9cd3bd0ca9426bbfd381b79c3ef4d06b49c2/static/assets/tutorials/cumulus/chain-specs/rococo-custom-2-raw\\.json$"
}
]
}
2 changes: 0 additions & 2 deletions runtime/amplitude/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,8 +606,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = MaxAuthorities;
type AllowMultipleBlocksPerSlot = ConstBool<false>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}

parameter_types! {
Expand Down
2 changes: 0 additions & 2 deletions runtime/foucoco/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,8 +582,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = MaxAuthorities;
type AllowMultipleBlocksPerSlot = ConstBool<false>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}

parameter_types! {
Expand Down
2 changes: 0 additions & 2 deletions runtime/pendulum/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,8 +611,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = MaxAuthorities;
type AllowMultipleBlocksPerSlot = ConstBool<false>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
parameter_types! {
pub const LaunchPeriod: BlockNumber = 5 * DAYS;
Expand Down
Loading