Repository navigation
fix: prepare database-check options query with literal placeholders (#228) - #237
Merged
Merged
Conversation
…228) Plugin Check flagged the dynamically built WHERE clause as an unescaped parameter. Write the four LIKE %s clauses into the query directly, like the sibling checks, and drop the phpcs:disable block. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last non-inherent Plugin Check warning before the WP.org resubmission (
PluginCheck.Security.DirectDB.UnescapedDBParameteratdatabase-check.php:305).The WHERE clause was built with
implode()from fixed fragments behind aphpcs:disableblock. It now writes the fourLIKE %sclauses directly into the query, the same way the other checks in the file do.Tested: with two planted options, the check returns both (same result as before). Plugin Check reports nothing for the file.
🤖 Generated with Claude Code