Skip to content

fix: prepare database-check options query with literal placeholders (#228) #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pluginslab merged 1 commit into from
Sep 25, 2026
Merged

fix: prepare database-check options query with literal placeholders (#228) #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 10 additions & 23 deletions includes/abilities/security/database-check.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,35 +283,22 @@ function agentic_admin_check_options_eval(): array {
function agentic_admin_check_options_suspicious_urls(): array {
global $wpdb;

$suspicious_patterns = array(
'%' . $wpdb->esc_like( '<script' ) . '%',
'%' . $wpdb->esc_like( 'document.write' ) . '%',
'%' . $wpdb->esc_like( 'window.location' ) . '%',
'%' . $wpdb->esc_like( 'String.fromCharCode' ) . '%',
);

$where_clauses = array();
$values = array();
foreach ( $suspicious_patterns as $pattern ) {
$where_clauses[] = 'option_value LIKE %s';
$values[] = $pattern;
}

// The WHERE clause is built from literal "option_value LIKE %s" fragments
// in a fixed-size loop over $suspicious_patterns — no user input touches
// the SQL string. The %s count always matches ...$values, but phpcs can't
// see through the implode + spread to verify that statically.
// phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching,WordPress.DB.PreparedSQLPlaceholders.ReplacementsWrongNumber,WordPress.DB.PreparedSQL.NotPrepared,WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare
// phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching
$rows = $wpdb->get_results(
$wpdb->prepare(
"SELECT option_name, LEFT(option_value, 200) AS option_value_preview
FROM {$wpdb->options}
WHERE " . implode( ' OR ', $where_clauses ) . '
LIMIT 50',
...$values
WHERE option_value LIKE %s
OR option_value LIKE %s
OR option_value LIKE %s
OR option_value LIKE %s
LIMIT 50",
'%' . $wpdb->esc_like( '<script' ) . '%',
'%' . $wpdb->esc_like( 'document.write' ) . '%',
'%' . $wpdb->esc_like( 'window.location' ) . '%',
'%' . $wpdb->esc_like( 'String.fromCharCode' ) . '%'
)
);
// phpcs:enable WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching,WordPress.DB.PreparedSQLPlaceholders.ReplacementsWrongNumber,WordPress.DB.PreparedSQL.NotPrepared,WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare

$findings = array();
foreach ( $rows as $row ) {
Expand Down
Loading