Defer FX graph stringification until DEBUG logging is enabled. - #4598
Draft
micwill755 wants to merge 1 commit into
Draft
Defer FX graph stringification until DEBUG logging is enabled.#4598micwill755 wants to merge 1 commit into
micwill755 wants to merge 1 commit into
Conversation
4 tasks
micwill755
force-pushed
the
lazy-graph-printing
branch
from
September 1, 2026 18:30
9529f21 to
2ab2bab
Compare
logger.debug("..." + str(gm.graph)) and f-string graph dumps build the full graph even at INFO. Pass gm.graph as a %s argument so Graph.__str__ runs only when the line is emitted.
micwill755
force-pushed
the
lazy-graph-printing
branch
from
September 2, 2026 07:06
2ab2bab to
79252a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logger.debugcall.logger.debug("…" + str(gm.graph))and f-string dumps runGraph.__str__even at INFO.gm.graphas a%sargument so Python logging formats it only when DEBUG is actually enabled.compile/refit/torch.compilebackend and the lowering passes that dumped the graph after each rewrite).PR 7 of the compile-startup stack; based on #4597.
Test plan
tests/py/dynamo/lowering/test_lazy_graph_printing.py(source scan for eagerstr(gm.graph)in dynamo debug logs;constant_folddoes not stringify at INFO and still does at DEBUG)Stack created with GitHub Stacks CLI • Give Feedback 💬