Skip rebuilding FX forward after post-lowering and before adjacency split. - #4599
Draft
micwill755 wants to merge 1 commit into
Draft
Skip rebuilding FX forward after post-lowering and before adjacency split.#4599micwill755 wants to merge 1 commit into
micwill755 wants to merge 1 commit into
Conversation
micwill755
force-pushed
the
skip-conversion-recompile
branch
from
September 1, 2026 18:30
d976ba1 to
17b63ed
Compare
…plit. TRTInterpreter and AccNodesFinder walk graph.nodes; split still rebuilds forward when it constructs the runtime GraphModules.
micwill755
force-pushed
the
skip-conversion-recompile
branch
from
September 2, 2026 07:06
17b63ed to
c722fbb
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gm.recompile()in the post-lowering flush (defaultrecompile=False) and infast_partitionbeforesplit(). Conversion (TRTInterpreter) and the adjacency splitter walkgraph.nodesand do not callgm.forward().post_lowering(..., recompile=True)(converter harness, LLM static-cache).split()still rebuildsforward()when it constructs_run_on_acc_*/_run_on_gpu_*GraphModules.fast_partitionwall is 118 ms (was ~155–171 ms).split()still reprints the full ACC child twice (~37 ms each) plus an expensive 9-node wrapper reprint (~36 ms).PR 8 of the compile-startup stack; based on #4598.
Test plan
tests/py/dynamo/lowering/test_skip_conversion_recompile.py(post_lowering does not recompile; DCE still runs; Interpreter still correct;recompile=Truerebuilds forward; fast_partition does not recompile the input module)tests/py/dynamo/models/test_lowering_cache.py(roundtrip still executes after explicit recompile of the in-memory module)tests/py/dynamo/partitioning/test_000_fast_partitioning.pyStack created with GitHub Stacks CLI • Give Feedback 💬