Repository navigation
fix: revert broken IME input handling code - #67
Merged
Merged
Conversation
Reverts the IME-related changes from v0.0.27-v0.0.29 that broke Chinese input in terminal TUI apps. The removed code (isComposing checks, composition event listeners) conflicted with xterm.js's built-in IME support, causing Chinese input to fail in TUI applications like Claude Code. xterm.js already handles IME input correctly out of the box - no additional handling is needed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isComposingchecks,compositionstart/endevent listeners) conflicted with xterm.js's built-in IME supportRoot Cause
The added code in
attachCustomKeyEventHandlerand composition event listeners interfered with xterm.js's internal IME processing, causing Chinese input to fail in TUI applications like Claude Code.Test plan
claudeto enter TUI mode🤖 Generated with Claude Code