Skip to content

fix: revert broken IME input handling code #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qfxiongbinbin merged 1 commit into from
Apr 16, 2026
Merged

fix: revert broken IME input handling code #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions ServerDeck/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,15 +297,6 @@ function isTerminalViewportNearBottom(terminal: Terminal) {
return activeBuffer.baseY - activeBuffer.viewportY <= 1;
}

function clearDocumentSelection() {
const selection = window.getSelection();
if (!selection || selection.rangeCount === 0) {
return;
}

selection.removeAllRanges();
}

const MAX_TERMINAL_BUFFER_CHUNKS = 800;
const MAX_TERMINAL_BUFFER_CHARS = 400_000;

Expand Down Expand Up @@ -2079,16 +2070,8 @@ export default function App() {
terminal.open(terminalMountNode);
const clearSelectionFrame = window.requestAnimationFrame(() => {
terminal.clearSelection();
clearDocumentSelection();
terminal.focus();
});
let isTerminalComposing = false;

terminal.attachCustomKeyEventHandler((event) => {
if (event.isComposing || event.keyCode === 229) {
return true;
}

const sequence = getTerminalControlSequence(event);
if (!sequence) {
return true;
Expand All @@ -2112,26 +2095,8 @@ export default function App() {
});
}

const terminalTextarea = terminal.textarea;
const handleCompositionStart = () => {
isTerminalComposing = true;
};
const handleCompositionEnd = () => {
isTerminalComposing = false;
};
terminalTextarea?.addEventListener("compositionstart", handleCompositionStart);
terminalTextarea?.addEventListener("compositionend", handleCompositionEnd);

const disposable = terminal.onData((data) => {
sendActiveTerminalInput(data);

if (data === "\r" && !isTerminalComposing) {
window.requestAnimationFrame(() => {
terminal.focus();
terminal.clearSelection();
clearDocumentSelection();
});
}
});

let frameId: number | null = null;
Expand Down Expand Up @@ -2166,8 +2131,6 @@ export default function App() {
}
window.cancelAnimationFrame(clearSelectionFrame);
disposable.dispose();
terminalTextarea?.removeEventListener("compositionstart", handleCompositionStart);
terminalTextarea?.removeEventListener("compositionend", handleCompositionEnd);
terminal.dispose();
terminalRef.current = null;
fitAddonRef.current = null;
Expand Down