Skip to content

Close non-design skill authority and host-trust gaps - #14

Merged
mosobande merged 1 commit into
orifrom
fix/non-design-review-findings
Aug 16, 2026
Merged

Close non-design skill authority and host-trust gaps#14
mosobande merged 1 commit into
orifrom
fix/non-design-review-findings

Conversation

@mosobande

@mosobande mosobande commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Why

The repository-wide skill review found non-design contract and integration defects in the pull-request workflows and repository documentation. seda-pr contradicted its required publication workflow, and both seda-pr and wo-pr could begin provider operations against an unconfirmed custom host. The Claude Code instruction file and README also made claims that did not match their owning files.

Design-skill findings are intentionally excluded. They are already handled by PR #9.

What changed

  • Make a seda-pr invocation authorize bounded staging, commit, and non-force push together with one ready PR or MR.
  • Keep progress comments, human notifications, issue-closing effects, force-push, approval, merge, and close outside that authority.
  • Reject enterprise, dedicated, and self-managed GitHub or GitLab hosts before provider contact unless the exact normalized host receives separate trust.
  • Preserve default trust for github.com and gitlab.com.
  • Update existing provider tests to prove that rejection happens before subprocess.run.
  • Change CLAUDE.md to import @AGENTS.md.
  • Limit the README changelog description to the baseline and release scope that the changelog contains.
  • Update the existing minor Changeset with the complete user-visible scope.

Verification

  • Seda PR provider suite: 17/17 passed.
  • Wo PR provider suite: 35/35 passed.
  • All 28 agents/openai.yaml files parsed successfully.
  • npx changeset status found the expected minor package bump.
  • Changed direct references exist.
  • git diff --check passed.
  • Remote branch head read back as f49041650bb7bb2e5cd436774444bfc210c5f1d2 after push.

The first metadata check attempted to use an unavailable local Node yaml package. The final check used the system Ruby YAML parser and passed. No external provider API behavior was exercised beyond GitHub PR publication.

Review focus

  • Confirm that the seda-pr invocation boundary matches its publish workflow without granting notification, issue-closing, force-push, approval, merge, or close authority.
  • Confirm that custom-host rejection occurs before any provider runner is called and that exact trusted-host and default-host paths remain available.
  • Check that the two repository-documentation corrections do not imply unsupported host behavior.

Contribution map

  • Publication authority and host gate: skills/seda-pr.
  • Monitoring host gate: skills/wo-pr.
  • Host integration: CLAUDE.md.
  • Release documentation: README.md and .changeset/fresh-skill-validation.md.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@mosobande mosobande added bug Something isn't working documentation Improvements or additions to documentation labels Aug 16, 2026
@mosobande
mosobande merged commit e8c9f30 into ori Aug 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant