Harden design skill routing and token contracts - #9
Open
mosobande wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The design-skill system had overlapping ownership, stale helper claims, prohibited default-prompt metadata, and token contracts that did not match slide generation. These gaps could route focused work to the wrong owner, advertise behavior that helpers did not provide, or generate slides against an incomplete token source.
What changed
README.md, and removeolofofoandsalayefrom Alarina routing.apere.default_promptfrom all seven affected design-skill metadata files.banner-designowns constrained banner surfaces;apereowns its built-in visual modes;amoye-ui-uxrecommends or reviews UI direction;asa-oju-ibanisoroowns React implementation.python3, align Brand and Banner claims with their helpers, and remove the unrelated canvas workflow.Critical contracts
banner-design; posts, carousels, stories, templates, and multi-format systems route toapere.eto-apereowns token declarations.slidesconsumes that contract and stops when a required artifact or referenced CSS variable is missing.var(--token)references. Canonical state naming puts the state last, such as--button-bg-hover.var(--token)color references and rejects raw CLI colors; Tailwind CSS 4 remains CSS-first through@theme.Verification
048865a.Existing pytest-based Apere and Brand suites did not run because
pytestis not installed. Their affected helpers received targeted syntax and smoke checks. No browser render, overflow, or visual contrast pass was run.Current-base integration
Merge commits
4675cfdand4bc6448integrate the latestori, including merged PR #14, without rewriting PR history. The only textual conflict wasskills/alarina/SKILL.md; its resolution keeps PR #9's removal ofolofofoandsalayeroutes while preserving the currentseda-prcommit-and-push route.Fresh proof on the merged head: Amoye 39/39, Slides 3/3, Seda 17/17, Wo 35/35, data validation, all 28 metadata files parsed, no prohibited
default_prompt, no unsupported documentedpythoninvocation in the four affected skills, the single-deliverable Apere route is present,CLAUDE.mdand README integration fixes remain present, Changesets reports the expected minor bump, and diff checks pass. The remote head read back as4bc6448b3d4a6ff04d9166be66ba45e26320941d.Review focus
apere/banner-designandamoye-ui-ux/asa-oju-ibanisoroownership boundaries.skills/eto-apere/scripts/generate-tokens.cjs.skills/slides/scripts/generate-slide.pywith undefined-variable enforcement inhtml-token-validator.py.Contribution map
README.md,skills/alarina,skills/apere,skills/banner-design.skills/amoye-ui-ux,skills/brand.skills/asa-oju-ibanisoro.skills/eto-apere.skills/slides..changeset/harden-design-skill-system.md.