[armanist]

Closes #596. Part of #595. The changelog entry is written in a final pull request, after the sub-issues.

What changed

• composer.json requires symfony/console, symfony/var-dumper and symfony/var-exporter at ^6.4 instead of ^5.4 (^5.2 for var-exporter). The update also drops symfony/polyfill-php73, which is no longer needed.
• CliCommand::confirm() says that the question helper is a QuestionHelper. Symfony 6.4 types getHelper() as the general HelperInterface, which has no ask(), so PHPStan could no longer see the method. Nothing changes at runtime.

Why

The minimum PHP version is 8.1 since #600, and Symfony 6.4 needs PHP 8.1. The other Symfony components in the dependency tree (event-dispatcher, filesystem, finder, process, yaml and others) are already on 6.4, while these three stayed on the 5.4 line only because of our constraints.

It also unblocks psr/log 3 (#599): symfony/console 5.4 declares a conflict with it.

Breaking changes

• None expected in the framework. CliCommand already declared configure(): void and execute(): int, and no other Symfony method is overridden. An application with its own subclass of a Symfony class could be affected by Symfony 6's stricter return types.

Testing

• No new tests: the existing console tests cover the code that changed, including CliCommand::confirm() and the full console boot and run, and they pass on Symfony 6.4.
• The full suite on PHP 8.1 gives the same results as master before the update.
• composer audit reports no security advisories.
• Known gap: PHP 8.2 and 8.3 run only in CI, and the starter project was not run against Symfony 6.4.

Notes for reviewers

• symfony/var-dumper is required but nothing in the framework imports it. It stays, now on 6.4, because applications may call its global dump() and dd(). Removing it would be a breaking change and belongs to a separate decision.
• The starter project pins symfony/process and symfony/yaml to ^5.4 and still allows PHP 8.0. It needs its own update for PHP 8.1.

Summary by CodeRabbit

• Chores

  • Updated package version requirements to target Symfony 6.4.
  • Added type information for interactive console input.

• Bug Fixes

  • No end-user behavior changes are included in this update.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: ef5fc13f-378c-40d3-8605-7f0b55c7bea7

📥 Commits

Reviewing files that changed from the base of the PR and between c4150d1 and fa204e5.

📒 Files selected for processing: 2

• composer.json
• src/Console/CliCommand.php

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Symfony var-dumper, var-exporter, and console dependency constraints move to version 6.4. CliCommand imports QuestionHelper and adds a type annotation for the helper used by confirm().

Changes: Symfony 6.4 upgrade

Layer / File(s)	Summary
Dependency constraints and console helper typing composer.json, src/Console/CliCommand.php	The three Symfony dependency constraints change to ^6.4. CliCommand imports QuestionHelper and adds a type annotation for the helper used by confirm(). The annotation does not change runtime behavior.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related issues

• Allow psr/log 3 next to psr/log 2 #599 — This upgrade meets the Symfony Console 6.4 prerequisite described for allowing psr/log 3, but does not change the psr/log constraint.
• Raise the minimum PHP version to 8.1 and test every supported PHP branch in CI #595 — This implements the Symfony 6.4 portion of the PHP 8.1 update.

Possibly related PRs

• quantum-php/framework#600 — This PR updates Symfony package constraints as part of the PHP 8.1 compatibility work.

Suggested reviewers: andrey-smaelov

Merge Risk: ⚪ Minimal · up to fa204

The dependency upgrade and annotation change have no established functional regression; normal project validation remains appropriate.

Pre-merge checks: 4 · 1

Failed checks: 1 inconclusive

Check name	Status	Explanation	Resolution
Linked Issues check		For #596, composer.json changes symfony/console, symfony/var-dumper, and symfony/var-exporter to ^6.4. CliCommand::confirm() adds the QuestionHelper type annotation required for PHPStan.…	Provide reviewable results for composer cs:check, composer phpstan, and composer rector:check, and verify php qt in the starter project. The available evidence does not show whether these requirements pass.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely identifies the main change: moving the specified Symfony packages to the 6.4 LTS line.
Out of Scope Changes check		The diff contains only the three Symfony constraint updates and the QuestionHelper annotation in CliCommand::confirm(). These changes directly support #596. No unrelated source or dependency chang…
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …

Full details: Out of Scope Changes check

Explanation

The diff contains only the three Symfony constraint updates and the QuestionHelper annotation in CliCommand::confirm(). These changes directly support #596. No unrelated source or dependency change is present.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

Full details: Linked Issues check

Explanation

For #596, composer.json changes symfony/console, symfony/var-dumper, and symfony/var-exporter to ^6.4. CliCommand::confirm() adds the QuestionHelper type annotation required for PHPStan. The reviewable diff does not establish results for composer cs:check, composer phpstan, or composer rector:check. The PR also states that the starter project was not run, so php qt operation is not established. The changelog omission is deferred and is a non-coding task.

Resolution

Provide reviewable results for composer cs:check, composer phpstan, and composer rector:check, and verify php qt in the starter project. The available evidence does not show whether these requirements pass.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!