[armanist]

Closes #627.

What changed

• .github/workflows/php.yml: the triggers are now

  on:
    push:
      branches: [ "master", "*.x" ]
    pull_request:

  pull_request has no branches filter, so a pull request into any branch runs the workflow, and push runs for master and for any branch whose name ends in .x, such as 3.1.x and a later 3.2.x, without another edit.

• Nothing else in the workflow changes: the PHP matrix, the services, the style, analysis and test steps, and the coverage upload.

Why

The workflow listed branches: ["master"] under both push and pull_request, so a pull request into the maintenance branch 3.1.x ran no checks, and neither did a push to it. Laravel and Symfony keep the triggers open the same way (push on a branch pattern, pull_request: with no filter).

A merged pull request is a push to its target branch, so CI also runs on the merged result, as it does on master today.

Breaking changes

None.

Testing

There is no PHP test for a workflow file. The file parses as valid YAML with the same single job, the pull_request trigger has no branches filter, and the *.x pattern, read with GitHub's rule that * does not match /, matches 3.1.x, 3.2.x and 3.10.x but not master, 3.1.0, 3.1 or a ticket branch such as issue/627-ci-branch-triggers.

Notes for reviewers

• This pull request targets 3.1.x and gets no CI itself: a pull request runs the workflow file of its base branch, and 3.1.x still has the old filter. The first run is the push after the merge.
• master needs the same change. It arrives when 3.1.x is merged into master.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5398ab51-3d1d-452a-b439-49dbf63b62e4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!