Repository navigation
RDKEMW-26354 : Add UNLOADED lifecycle state support - #118
Closed
swethasukumarr wants to merge 1 commit into
Closed
swethasukumarr wants to merge 1 commit into
swethasukumarr wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The canonical lifecycle schema remains outdated, so regeneration would remove this change and leave generated specifications inconsistent.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds support for the UNLOADED lifecycle state across the public API, JSON deserialization, OpenRPC fixture, and tests.
Changes:
- Adds the
UNLOADEDenum and wire mapping. - Adds unit and component coverage for unloaded states.
- Updates the generated OpenRPC fixture.
| File | Description |
|---|---|
include/firebolt/lifecycle.h |
Exposes the new lifecycle state. |
src/json_types/lifecycle.h |
Maps the unloaded wire value. |
test/unit/lifecycleTest.cpp |
Tests getter deserialization. |
test/component/lifecycleTest.cpp |
Tests unloaded state-change events. |
docs/openrpc/the-spec/firebolt-open-rpc.json |
Adds the state to the generated schema. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "hibernated", | ||
| "terminating" | ||
| "terminating", | ||
| "unloaded" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.