Skip to content

RDKEMW-26354 : Add UNLOADED lifecycle state support #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swethasukumarr wants to merge 1 commit into from
Closed

RDKEMW-26354 : Add UNLOADED lifecycle state support #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/openrpc/the-spec/firebolt-open-rpc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4966,7 +4966,8 @@
"paused",
"suspended",
"hibernated",
"terminating"
"terminating",
"unloaded"
]
},
"StateChange": {
Expand Down
1 change: 1 addition & 0 deletions include/firebolt/lifecycle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ enum class LifecycleState
SUSPENDED,
HIBERNATED,
TERMINATING,
UNLOADED,
};

/**
Expand Down
1 change: 1 addition & 0 deletions src/json_types/lifecycle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ inline const Firebolt::JSON::EnumType<::Firebolt::Lifecycle::LifecycleState> Lif
{"suspended", ::Firebolt::Lifecycle::LifecycleState::SUSPENDED},
{"hibernated", ::Firebolt::Lifecycle::LifecycleState::HIBERNATED},
{"terminating", ::Firebolt::Lifecycle::LifecycleState::TERMINATING},
{"unloaded", ::Firebolt::Lifecycle::LifecycleState::UNLOADED},
});

class LifecycleState : public Firebolt::JSON::NL_Json_Basic<::Firebolt::Lifecycle::LifecycleState>
Expand Down
25 changes: 25 additions & 0 deletions test/component/lifecycleTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,3 +132,28 @@ TEST_F(LifecycleCTest, subscribeOnState_noValue)
auto result = Firebolt::IFireboltAccessor::Instance().LifecycleInterface().unsubscribe(id.value());
verifyUnsubscribeResult(result);
}

TEST_F(LifecycleCTest, subscribeOnState_unloaded)
{
auto id = Firebolt::IFireboltAccessor::Instance().LifecycleInterface().subscribeOnStateChanged(
[&](const std::vector<Firebolt::Lifecycle::StateChange>& changes)
{
EXPECT_TRUE(!changes.empty());
EXPECT_EQ(changes[0].newState, Firebolt::Lifecycle::LifecycleState::UNLOADED);
EXPECT_EQ(changes[0].oldState, Firebolt::Lifecycle::LifecycleState::TERMINATING);

{
std::lock_guard<std::mutex> lock(mtx);
eventReceived = true;
}
cv.notify_one();
});
verifyEventSubscription(id);

triggerEvent("Lifecycle2.onStateChanged", R"({"value":[{"newState":"unloaded","oldState":"terminating"}]})");

verifyEventReceived(mtx, cv, eventReceived);

auto result = Firebolt::IFireboltAccessor::Instance().LifecycleInterface().unsubscribe(id.value());
verifyUnsubscribeResult(result);
}
8 changes: 8 additions & 0 deletions test/unit/lifecycleTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ TEST_F(LifecycleUTest, stateBadResponse)
ASSERT_FALSE(result) << "LifecycleImpl::state() did not return an error";
}

TEST_F(LifecycleUTest, stateUnloaded)
{
mock_with_response("Lifecycle2.state", "unloaded");
Firebolt::Result<Firebolt::Lifecycle::LifecycleState> result = lifecycleImpl_.state();
ASSERT_TRUE(result) << "Failed to retrieve current state from Lifecycle.state() method";
EXPECT_EQ(*result, Firebolt::Lifecycle::LifecycleState::UNLOADED);
}

TEST_F(LifecycleUTest, subscribeOnStateChanged)
{
EXPECT_CALL(mockHelper, subscribe(_, "Lifecycle2.onStateChanged", _, _))
Expand Down
Loading