You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Small, correct cleanup. I verified the underlying claim: engine/sdks/rust/envoy-client/src/config.rs no longer defines HttpRequestBodyStream or HTTP_BODY_STREAM_CHANNEL_CAPACITY — only HttpRequest, HttpResponse, ResponseChunk, EnvoyConfig, etc. remain. So the removed pub use items in rivetkit-rust/packages/rivetkit-core/src/lib.rs were re-exporting nonexistent paths, which would fail to compile as-is. Dropping them and keeping ResponseChunk (which still exists in config.rs) is the right fix.
A few notes, none blocking this PR:
Related dangling reference elsewhere: rivetkit-typescript/packages/rivetkit-napi/tests/actor_factory.rs still imports rivetkit_core::HttpRequestBodyStream as CoreHttpRequestBodyStream and use super::{..., HttpRequestBodyStream, ...}, and constructs CoreHttpRequestBodyStream::new(...). Neither rivetkit_core::HttpRequestBodyStream nor a module-local HttpRequestBodyStream exist anywhere in the current tree (checked actor_factory.rs src, which doesn't define or import that name). That test file looks like it was already broken before this change — this PR doesn't cause it, but since it's the same identifier being cleaned up here, it'd be worth a follow-up to either restore the type where the tests expect it or delete/update the now-stale test code.
Test coverage: this is a pure re-export removal with no behavior change, so no new tests are needed — makes sense that none were added.
PR description is empty. Per repo convention, even a one-line "why" bullet is nice to have, though for a mechanical revert like this it's low value.
No security, performance, or logging concerns — this is just narrowing a public re-export surface to match what actually exists upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.