Skip to content

chore(container-runner): default stop grace to 10s - #5533

Open
abcxff wants to merge 1 commit into
stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpumfrom
stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup
Open

chore(container-runner): default stop grace to 10s#5533
abcxff wants to merge 1 commit into
stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpumfrom
stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup

Conversation

@abcxff

@abcxff abcxff commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@abcxff

abcxff commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@claude

claude Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review: chore(container-runner): default stop grace to 10s

Small, self-contained change: lowers the default --stop-grace-secs / RIVET_STOP_GRACE_SECS (SIGTERM→SIGKILL grace period for the child process) from 25s to 10s in container-runner/src/main.rs.

Code quality

  • Change is minimal and matches the CLAUDE.md guidance to avoid unrelated churn — just the default_value_t.
  • Downstream usage (effective_stop_grace(), sleep_grace_period: stop_grace + Duration::from_secs(10)) is defined relative to stop_grace, so lowering the constant doesn't break any invariant. The sleep grace deadline still outlives the SIGTERM→SIGKILL window as documented in the comment near container-runner/src/main.rs:311.
  • No test coverage exists for the CLI default itself, which is fine since this is a plain clap default rather than logic; not worth adding a test for.

Doc drift (found, worth fixing)

website/src/content/docs/deploy/container-runner.mdx:81 still documents the old default:

| `--stop-grace-secs` | `RIVET_STOP_GRACE_SECS` | `25` | ...

This should be updated to 10 in the same PR to match the new default, since it is user-facing reference documentation for this exact flag.

Other notes

  • No security or performance concerns. This only affects how long a child process is given to exit gracefully before being force-killed, and 10s is still generous for most workloads.
  • Worth double-checking with the author whether 10s is long enough for slower game-server shutdown sequences (e.g. flushing state or save-on-exit). This is a behavior change for existing deployments relying on the previous 25s default, not just for new installs.

@abcxff
abcxff force-pushed the stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup branch from 4a79659 to 395bd37 Compare July 31, 2026 06:03
@abcxff
abcxff force-pushed the stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpum branch from efaf873 to 11b03c3 Compare July 31, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant