Repository navigation
Conversation
a-shannon
marked this pull request as ready for review
September 26, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Zcash address, extraction, and native transaction support
Summary
Add transparent Zcash address handling to the shared codec, a Zebra RPC Rosen
deposit extractor, and bounded native inspector/payment sources with locked Rust
dependencies. The inspector exposes transaction structure without deciding Rosen
admission; the payment primitive constructs and validates exact transparent v5
payments and ZIP-244 digests.
Validation
documented public fixtures.
guard, watcher, and UI candidate graph.
Current native and extraction checks
The extractor now hashes and invokes the native helper asynchronously in bounded
batches (32 transactions and 2 MB of decoded bytes). Ordered, strict native results
remain authoritative even when RPC output projections are malformed. A failure
cannot return a partial batch.
The locked librustzcash pin is
5345dbe0cd6c7f2057e631a34a74dffa84ff1d48.NU7 branch
77190ad9is recognized: the inspector covers v5/v6 and rejects v4;the payment primitive covers v5 construction and actual CHECKSIG, including
rejection of a signature from the previous branch. Payment v6 and post-NU6.2
Orchard remain outside that payment profile.
Current checks: 29 native inspector tests, 24 native payment tests (including
the retained Orchard proof), 11 native wrapper tests and 25 extraction tests;
affected TypeScript/build/lint pass. Independent review covered the exact changes.
These are parser, signature and local consumer checks, not NU7 node admission or
an activation schedule.
Coordination
Coordinating review and all seven PRs.
The cross-repository scope and evidence are recorded in the
Zcash integration review.
The Changesets remain authoritative for versions. Official package/native releases,
consumer lock regeneration, and hosted CI are still required before deployment.