Repository navigation
Conversation
Native-only contribution with scoped validation. Maintainer releases, upstream acceptance and operational activation remain pending.
|
Reviewed at watcher #17 fff071b, scanner #16 d7bc0912eb, utils #11 19f49e906d, from the watcher-operator side, using the Zcash review as a checklist. Good: A consensus-valid block can stall BCH scanning indefinitely: Failed BCH fee init leaves the process partially started: any failed fee-box read or deadline expiry makes Commitment safety under the cleanup rule: the Rosen team confirmed (2026-09-29) that a guard-rejected trigger is fraud-spent after cleanup-confirm (~30 days) without re-verification, slashing the merged watchers. The PR ships no BCH depth guidance. With stock BCHN, finalization isn't a fixed confirmation count: Shared-path changes for every chain: utils #11 adds RPC exposure: any HTTP(S) URL is accepted, including plain Node and release: which BCHN release and config are qualified? BCHN announced v29.2.0 on 2026-10-02 and says it will refuse to start if Release order: at these pinned SHAs, the lockfile has no entries for the BCH packages or libauth, so Smaller: the codec is mainnet-only while config offers test/regtest; |
|
Took another look at ecc8abb (scanner 10e951c46b; matrix at guard-service 5a33942061). Finality gate: this looks right to me — exact persisted block on active ancestry at or below
Shared-module boundary: from the operator side I'd support the dedicated BCH extractor entry or package rather than accepting the eager root export, with an acceptance test that a non-BCH watcher's emitted startup graph never loads libauth. That keeps the BCH runtime risk with the BCH deployment. |
Add opt-in native Bitcoin Cash scanning, separate observation/extractor entry, bounded fee readiness and proposed finality checks before signing/broadcast. Configuration forwards scanner work budgets and records endpoint/finality diagnostic health without granting eligibility from health alone.
Independent runtime/build and persisted queue-height fixes are extracted into separate prepared prerequisites. The exact retained BCH retry fails on the unpatched baseline and passes with the height-only update; three generic SQLite stale-state cases also pass. The separate installed build preparation passes 19 cases, including real SQLite/Snappy and source-entry loading. Those results do not establish a released BCH installation, default CI/image build or accepted runtime direction.
Earlier composed Watcher startup and cleanup observations depend on the now-separated prerequisites; they do not certify the restored baseline entry. Required packages, runtime/build/retention integration and ordinary lock regeneration remain pending.
This updates an existing draft's scope and operator-review evidence. Related RCS document and matrix review, finality/design acceptance, independent endpoints and operational activation remain open. It does not request chain-code review before RCS review.
Coordinated drafts: Utils #11, Scanner #16, Guard #29, Health Check #5, UI #33.