[1steve78]

Closes #2695

Summary

Workshop variation ideas and story ideas record which organization they originated from, but workshop ideas did not have an organization_id column or dropdown.

This PR implements organization tracking on workshop_ideas and workshops, following the #2693 scoping pattern:

• Users with a single active affiliation have their organization automatically populated via a hidden field.
• Users with multiple active affiliations (and admins, who see all organizations) are presented with an organization dropdown.
• The organization field is optional on both models.
• When promoting a WorkshopIdea to a Workshop, the organization_id is retained.
• The organization is displayed on the index and show views for both WorkshopIdea and Workshop.

---

Key Changes

1. Migrations & Schema

   • Added organization:references (type: :integer, null: true, foreign_key: true) to workshop_ideas.
   • Added organization:references (type: :integer, null: true, foreign_key: true) to workshops.

2. Models

   • WorkshopIdea: Added belongs_to :organization, optional: true.
   • Workshop: Added belongs_to :organization, optional: true.
   • Organization: Added has_many :workshop_ideas and direct has_many :workshops.

3. Controllers & Promotion

   • WorkshopIdeasController & WorkshopsController: Scoped @organizations in set_form_variables using authorized_scope(Organization.all, as: :currently_affiliated).order(:name) and permitted :organization_id in strong parameters.
   • WorkshopFromIdeaService: Preserves organization_id when promoting a WorkshopIdea to a Workshop.

4. Views & Forms

   • workshop_ideas/_form.html.erb & workshops/_form.html.erb: Implemented the #2693 dropdown pattern (hidden input when @organizations.size == 1, select prompt when > 1 or admin).
   • workshop_ideas/show.html.erb & workshop_ideas/index.html.erb: Displays organization name / link.
   • workshops/_show_header.html.erb & workshops/_index_row.html.erb: Displays organization name / link.

5. Tests

   • spec/models/workshop_idea_spec.rb & spec/models/workshop_spec.rb: Verified association and validity with and without an organization.
   • spec/models/organization_spec.rb: Verified have_many associations.
   • spec/services/workshop_from_idea_service_spec.rb: Verified organization_id persistence upon idea promotion.
   • spec/requests/workshop_ideas_spec.rb & spec/requests/workshops_spec.rb: Added admin and regular user request specs covering index, show, form rendering (hidden field vs dropdown), and CRUD actions.

---

How to Test

1. Run migrations: bin/rails db:migrate
2. Run test suites:
   • bundle exec rspec spec/models/workshop_idea_spec.rb spec/models/workshop_spec.rb spec/services/workshop_from_idea_service_spec.rb
   • bundle exec rspec spec/requests/workshop_ideas_spec.rb spec/requests/workshops_spec.rb
3. Manual verification:
   • Sign in as an admin -> navigate to /workshop_ideas/new -> verify all organizations appear in the Organization dropdown with a prompt.
   • Sign in as a user with 1 active organization affiliation -> navigate to /workshop_ideas/new -> verify the organization dropdown is hidden and populated with the user's active organization.
   • Create a WorkshopIdea with an organization and promote it to a Workshop -> verify the new Workshop preserves the organization.
   • Visit show and index pages for both WorkshopIdea and Workshop with and without an organization to verify graceful rendering.

---

Verification

• All RSpec tests pass (232 model/service specs, 67 request specs)
• RuboCop passed with 0 offenses
• Brakeman security scan passed with 0 warnings

[maebeale]

this wasn't in the spec, but on org profile we should put both workshops/ideas that are directly connected to the organization, and, also pull through the Affiliation > Person > Workshops/ideas authored (not user_id). would you be ok to add that this this pr so the list that shows on Org profile shows directly and indirectly associated workshops and ideas?

[maebeale]

we need include_blank: "Select organization" so they can remove an org/leave it blank

[maebeale]

thanks for working on this, @1steve78 ! left a few comments. and, would you add a seeds features file for this?

[1steve78]

Thanks for the review! I'll address all three comments by adding directly and indirectly associated workshops and ideas to the organization profile, allowing the organization field to be cleared using include_blank, and adding a feature spec for the new functionality. I'll also resolve the db/schema.rb merge conflict and run the relevant tests before pushing the updates.