Repository navigation
Conversation
With countries now stored as one dropdown name, searching by country finds everyone in it; contact-info search covered every other address column but country. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
#2825's contact-info box searches through search_contact, so country joins its attributes and the box's tooltip names it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/search-people-by-country
branch
from
October 25, 2026 08:27
4355b42 to
8b1dc5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 1 Skim 👀 two search attributes + a tooltip word
Stacked on #2825. People search's contact info now matches the country on a person's address, so "India" — or
address_country:"South Africa"— finds the people who live there.search_contact, which drives the people index's contact-info box (Adjust people index query #2825).search, used bysearch_by_params.🤖 Generated with Claude Code