Skip to content

test(harness): exercise assembled assistant lifecycle [SAP-3292] - #1027

Closed
ynadge wants to merge 1 commit into
assistant-server-wiringfrom
assistant-server-composition-tests
Closed

ynadge wants to merge 1 commit into
assistant-server-wiringfrom
assistant-server-composition-tests

Conversation

@ynadge

@ynadge ynadge commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Primary change type

  • Tests

Problem and motivation

Isolated lifecycle tests do not prove that the assembled Studio server shares authorization, durable continuation state, context delivery and event publication correctly.

Summary and scope

Exercise actual startServer with real access, project/session/record/receipt stores and lifecycle orchestration. Substitute only the native launcher/HTTP boundary and controlled local API. Cover default legacy Resume, unavailable Continue before allocation, activated Continue → Send → accepted-context recovery → End → Resume → explicit Terminal start, and hidden unfinished children across server restart.

Related work

Related issue: https://linear.app/sapiom/issue/SAP-3292

Depends on #1026. Native stack target: main.

Validation

pnpm --filter @sapiom/harness test — 4,780 unit tests and 10 performance tests passed; 2 unit tests skipped.

The new assembled-server fixture contributes four scenarios. Focused server/context validation passed 26 tests; server TypeScript, scoped ESLint and Prettier passed. A controlled mutation disconnecting shared recovery failed the accepted-context recovery assertion, then the source was restored.

Tests and documentation

Test-only change; no user-facing documentation changes needed. Increment: 859 changed lines including tests/docs/changeset; SDK pr:size is absent.

Compatibility and release impact

  • No runtime behavior or public API changes in this increment.
  • Changeset: N/A; tests only.
  • Fix-forward: correct a fixture or assertion in a focused test follow-up without weakening the lifecycle behavior it protects.

Security

  • No secrets, credentials, private data, or unsanitized logs included.
  • No suspected vulnerability disclosed publicly.

AI assistance

  • AI assistance used: Codex implemented and reviewed the change with the validation described above.

Checklist

  • CONTRIBUTING.md read; maintainer-authorized issue work.
  • One focused increment, checks, documentation and release impact addressed.
  • I can explain and maintain the submitted changes.

Devin Review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 235c7489-4747-4987-b7dd-abdc3d2e32ab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@ynadge ynadge closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant