Skip to content

test(opencode): isolate and measure native startup deadlines [SAP-3292] - #1028

Closed
ynadge wants to merge 1 commit into
assistant-server-composition-testsfrom
native-startup-ci-isolation
Closed

ynadge wants to merge 1 commit into
assistant-server-composition-testsfrom
native-startup-ci-isolation

Conversation

@ynadge

@ynadge ynadge commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Primary change type

  • Tests

Problem and motivation

The native offline-startup test enforces a 15-second end-to-end deadline while other native test files compete for CPU. Intel macOS failures currently lack phase timing, making readiness delays hard to locate.

Summary and scope

Run the four existing native test files serially, preserving the startup test's two live runtimes and all assertions. Emit bounded test-only startup phase timings without URLs, headers, configuration or native logs. Production deadlines and cancellation stay unchanged.

Related work

Related issue: https://linear.app/sapiom/issue/SAP-3292

Depends on #1027. Native stack target: main.

Validation

SAPIOM_OPENCODE_CONTEXT_TEST_BINARY=<selected E2 candidate> pnpm --filter @sapiom/opencode exec vitest run --no-file-parallelism src/assistant-context.native.test.ts src/startup-dependencies.native.test.ts src/runtime-identity.test.ts src/desktop-runtime-identity.test.ts — 46 tests passed.

pnpm --filter @sapiom/opencode typecheck, scoped ESLint, and git diff --check — passed. A controlled never-ready child failed at the existing deadline and completed cleanup. One-CPU experiments measured approximately 2.2× faster readiness with serial files; no local candidate crossed the 15-second deadline. Actual Intel CI remains the verification gate.

Tests and documentation

Preserves existing native assertions and adds failure diagnostics; production documentation unchanged. Increment: 78 changed lines including tests/docs/changeset; SDK pr:size is absent.

Compatibility and release impact

  • CI scheduling and test diagnostics only. Runtime version, source durability and activation are unchanged.
  • Changeset: N/A; CI and tests only.
  • Fix-forward: use the measured failing startup phase to correct forward; retain the production deadline and all native assertions.

Security

  • No secrets, credentials, private data, or unsanitized logs included.
  • No suspected vulnerability disclosed publicly.

AI assistance

  • AI assistance used: Codex implemented and reviewed the change with the validation described above.

Checklist

  • CONTRIBUTING.md read; maintainer-authorized issue work.
  • One focused increment, checks, documentation and release impact addressed.
  • I can explain and maintain the submitted changes.

Devin Review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3c357b89-52db-48bd-83ae-52146838e2a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant