Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary change type
Problem and motivation
The native offline-startup test enforces a 15-second end-to-end deadline while other native test files compete for CPU. Intel macOS failures currently lack phase timing, making readiness delays hard to locate.
Summary and scope
Run the four existing native test files serially, preserving the startup test's two live runtimes and all assertions. Emit bounded test-only startup phase timings without URLs, headers, configuration or native logs. Production deadlines and cancellation stay unchanged.
Related work
Related issue: https://linear.app/sapiom/issue/SAP-3292
Depends on #1027. Native stack target: main.
Validation
SAPIOM_OPENCODE_CONTEXT_TEST_BINARY=<selected E2 candidate> pnpm --filter @sapiom/opencode exec vitest run --no-file-parallelism src/assistant-context.native.test.ts src/startup-dependencies.native.test.ts src/runtime-identity.test.ts src/desktop-runtime-identity.test.ts— 46 tests passed.pnpm --filter @sapiom/opencode typecheck, scoped ESLint, andgit diff --check— passed. A controlled never-ready child failed at the existing deadline and completed cleanup. One-CPU experiments measured approximately 2.2× faster readiness with serial files; no local candidate crossed the 15-second deadline. Actual Intel CI remains the verification gate.Tests and documentation
Preserves existing native assertions and adds failure diagnostics; production documentation unchanged. Increment: 78 changed lines including tests/docs/changeset; SDK pr:size is absent.
Compatibility and release impact
Security
AI assistance
Checklist