Skip to content

fix(harness): fence assistant action results by binding [SAP-3292] - #1029

Closed
ynadge wants to merge 1 commit into
native-startup-ci-isolationfrom
assistant-action-authority
Closed

ynadge wants to merge 1 commit into
native-startup-ci-isolationfrom
assistant-action-authority

Conversation

@ynadge

@ynadge ynadge commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Primary change type

  • Bug fix

Problem and motivation

Inspect and Resume could return a result after a same-directory project or native binding changed, because the final route check compared only cwd and lifecycle revision.

Summary and scope

Compare the opaque authorized history scope before and after asynchronous work. Read the returned session after the final authorized history read so the response uses the current registry snapshot.

Related work

Related issue: https://linear.app/sapiom/issue/SAP-3292

Depends on #1028. Native stack target: main.

Validation

pnpm --filter @sapiom/harness exec vitest run src/server/assistant-lifecycle.test.ts src/server/assistant-lifecycle-wiring.test.ts — 18 tests passed.

Harness typecheck and scoped ESLint passed. Removing the scope comparisons failed all four new same-workspace rebinding cases; source restored and tests rerun.

Tests and documentation

Adds changed-scope and removed-scope coverage for both Inspect and Resume. Updated assistant-history.md. Increment: 40 changed lines including tests/docs/changeset; SDK pr:size is absent.

Compatibility and release impact

  • Stale responses now return the existing lifecycle_changed conflict; no new wire fields.
  • Changeset: @sapiom/harness patch.
  • Fix-forward: correct the final scope fence in a focused follow-up while retaining exact-binding validation.

Security

  • No secrets, credentials, private data, or unsanitized logs included.
  • No suspected vulnerability disclosed publicly.

AI assistance

  • AI assistance used: Codex implemented and reviewed the change with the validation described above.

Checklist

  • CONTRIBUTING.md read; maintainer-authorized issue work.
  • One focused increment, checks, documentation and release impact addressed.
  • I can explain and maintain the submitted changes.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2149288f-909e-4ca3-97a9-6560468c1eee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant