Skip to content

fix(harness): preserve continuation preparation deadline [SAP-3292] - #1030

Closed
ynadge wants to merge 1 commit into
assistant-action-authorityfrom
assistant-continuation-timeout
Closed

ynadge wants to merge 1 commit into
assistant-action-authorityfrom
assistant-continuation-timeout

Conversation

@ynadge

@ynadge ynadge commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Primary change type

  • Bug fix

Problem and motivation

Continue's 45-second operation budget was cut short by an inner 15-second inspection timer covering cold startup and frozen-context preparation.

Summary and scope

Give retained continuation preparation its own 45-second default budget. Keep read-only inspection at 15 seconds, preserve independent overrides, and retain shorter caller deadlines and immediate End cancellation.

Related work

Related issue: https://linear.app/sapiom/issue/SAP-3292

Depends on #1029. Native stack target: main.

Validation

pnpm --filter @sapiom/harness exec vitest run src/core/assistant-lifecycle-timeout.test.ts src/core/assistant-lifecycle.test.ts src/core/assistant-continuation.test.ts — 47 tests passed.

Harness typecheck, server build, scoped ESLint, new-file Prettier and diff checks passed. A pre-fix fake-clock run failed five assertions; the restored implementation passes.

Tests and documentation

Eight deadline scenarios cover startup plus preparation, exact retirement of late runtimes, independent inspection limits, End and caller cancellation. Updated assistant-history.md. Increment: 293 changed lines including tests/docs/changeset; SDK pr:size is absent.

Compatibility and release impact

  • Continue uses its documented budget; native startup itself retains its existing 15-second production deadline.
  • Changeset: @sapiom/harness patch.
  • Fix-forward: correct the preparation timer in a focused follow-up while retaining cancellation and exact runtime cleanup.

Security

  • No secrets, credentials, private data, or unsanitized logs included.
  • No suspected vulnerability disclosed publicly.

AI assistance

  • AI assistance used: Codex implemented and reviewed the change with the validation described above.

Checklist

  • CONTRIBUTING.md read; maintainer-authorized issue work.
  • One focused increment, checks, documentation and release impact addressed.
  • I can explain and maintain the submitted changes.

Devin Review

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c046ed60-bce0-4e9e-b154-6aeb77df7390

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant