Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary change type
Problem and motivation
A temporary-file removal failure could replace the unconfirmed-commit error after Assistant metadata publication and rollback failed, hiding the information needed to reconcile Resume.
Summary and scope
Settle all temporary removals and preserve the primary operation failure. Surface cleanup failure when publication otherwise succeeded, keeping uncertainty and cleanup errors observable.
Related work
Related issue: https://linear.app/sapiom/issue/SAP-3292
Depends on #1030. Native stack target: main.
Validation
pnpm --filter @sapiom/harness exec vitest run src/core/assistant-session-files.test.ts src/core/assistant-session-store.test.ts— 19 tests passed.Server TypeScript, scoped ESLint and diff checks passed. Restoring the masking behavior in memory failed both new primary-error regressions.
Tests and documentation
Covers uncertain publication plus rollback/cleanup failure, pre-publication failure plus cleanup failure, and cleanup failure following successful publication. Updated assistant-history.md. Increment: 88 changed lines including tests/docs/changeset; SDK pr:size is absent.
Compatibility and release impact
Security
AI assistance
Checklist