pkg/workflows/dontime: introduce feature flagged fix for sequence number inconsistency by jmank88 · Pull Request #2361 · smartcontractkit/chainlink-common

jmank88 · 2026-09-08T20:42:00Z

https://smartcontract-it.atlassian.net/browse/CRE-5838

Supports:

core/services/ocr2: pass limits factory to dontime plugin chainlink#23712

github-actions · 2026-09-08T20:43:22Z

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-common`

⚠️ Breaking Changes (1)

`pkg/workflows/dontime.(*Store)` (1)

GetDonTimes — 🗑️ Removed

✅ Compatible Changes (6)

`pkg/settings/cresettings.Schema` (1)

DonTimeSequencedTimestampsEnabled — ➕ Added

`pkg/workflows/dontime.(*Factory)` (1)

InitLimits — ➕ Added

`pkg/workflows/dontime/pb.(*ObservedDonTimes)` (3)

EarliestTS — ➕ Added
GetTimestampsBySequence — ➕ Added
MaxSeqNum — ➕ Added

`pkg/workflows/dontime/pb.ObservedDonTimes` (1)

TimestampsBySequence — ➕ Added

📄 View full apidiff report

…ber inconsistency

jmank88 · 2026-10-06T20:29:24Z

These were only used from tests.

jmank88 · 2026-10-06T20:30:12Z

I overlooked this before. Updated here and transmitter.

bolekk

lgtm

jmank88 requested a review from cedric-cordenier September 8, 2026 20:42

pkg/workflows/dontime: introduce feature flagged fix for sequence num…

9cc0558

…ber inconsistency

jmank88 force-pushed the CRE-5838-dontime-seqnums branch from 01f63a7 to 9cc0558 Compare September 8, 2026 22:14

jmank88 commented Sep 8, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/plugin.go Outdated

jmank88 requested a review from bolekk September 9, 2026 19:28

bolekk reviewed Sep 10, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/pb/dontime.go

Comment thread pkg/workflows/dontime/plugin.go Outdated

Comment thread pkg/workflows/dontime/plugin.go Outdated

jmank88 added 2 commits September 10, 2026 08:16

use donTime for feature flag

acb7626

adapt transmitter

880dc0e

jmank88 mentioned this pull request Sep 10, 2026

core/services/ocr2: pass limits factory to dontime plugin smartcontractkit/chainlink#23712

Draft

jmank88 requested a review from bolekk September 10, 2026 19:59

bolekk reviewed Sep 11, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/plugin.go Outdated

Comment thread pkg/workflows/dontime/plugin.go Outdated

Comment thread pkg/workflows/dontime/plugin.go Outdated

Comment thread pkg/workflows/dontime/plugin.go Outdated

Comment thread pkg/workflows/dontime/plugin.go Outdated

adjust donTime before usage; rm limitByBatchSizeFlag

4a8f4c7

jmank88 commented Sep 16, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/plugin.go Outdated

jmank88 added 2 commits September 15, 2026 18:22

cleanup; drop error cases

3a8a077

document map keys

9d52026

jmank88 requested a review from bolekk September 16, 2026 00:33

jmank88 added 2 commits September 16, 2026 07:39

restore unsequencedOutcome

f87a647

cleanup and error handling

304581e

jmank88 commented Sep 16, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/plugin.go Outdated

jmank88 added 2 commits September 16, 2026 16:53

remove irrelevant test

c596071

Merge remote-tracking branch 'origin/main' into CRE-5838-dontime-seqnums

6f54b4b

cedric-cordenier reviewed Sep 17, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/plugin.go Outdated

cleanup

e6db8f1

cedric-cordenier reviewed Sep 17, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/plugin.go Outdated

jmank88 added 5 commits September 17, 2026 09:21

don't assume current sequence number

1cc7d35

dedupe

fc1cd3b

simplify Observation

3039cbd

fix test

823f8fe

remove todo

92a8f3f

cedric-cordenier reviewed Sep 23, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/plugin.go Outdated

cedric-cordenier reviewed Sep 23, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/plugin.go Outdated

jmank88 added 4 commits September 29, 2026 07:15

sorted map iteration

8d54f75

Merge remote-tracking branch 'origin/main' into CRE-5838-dontime-seqnums

ff3176b

tests and fixes

2c8926a

handle flag reversion; fix store & transmitter

02cb2e4

jmank88 force-pushed the CRE-5838-dontime-seqnums branch from f5be451 to 02cb2e4 Compare October 6, 2026 20:28

jmank88 commented Oct 6, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/store_test.go

jmank88 Oct 6, 2026

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were only used from tests.

jmank88 commented Oct 6, 2026

View reviewed changes

Comment thread pkg/workflows/dontime/store.go

jmank88 Oct 6, 2026

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked this before. Updated here and transmitter.

Merge remote-tracking branch 'origin/main' into CRE-5838-dontime-seqnums

b9dc9eb

jmank88 requested a review from cedric-cordenier October 6, 2026 20:56

bolekk previously approved these changes Oct 7, 2026

View reviewed changes

Comment thread pkg/settings/cresettings/settings.go Outdated

Comment thread pkg/workflows/dontime/pb/dontime.go

cedric-cordenier previously approved these changes Oct 7, 2026

View reviewed changes

jmank88 added 2 commits October 7, 2026 15:46

Merge remote-tracking branch 'origin/main' into CRE-5838-dontime-seqnums

6ed2220

feedback

c5ba829

jmank88 dismissed stale reviews from cedric-cordenier and bolekk via c5ba829 October 7, 2026 20:54

jmank88 marked this pull request as ready for review October 7, 2026 20:54

jmank88 requested review from a team as code owners October 7, 2026 20:54

jmank88 requested review from bolekk and cedric-cordenier October 7, 2026 20:54

jmank88 enabled auto-merge October 7, 2026 20:54

Navigation Menu

Repository navigation

pkg/workflows/dontime: introduce feature flagged fix for sequence number inconsistency - #2361

pkg/workflows/dontime: introduce feature flagged fix for sequence number inconsistency#2361
jmank88 wants to merge 23 commits into
mainfrom
CRE-5838-dontime-seqnums

jmank88 commented Sep 8, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmank88 Oct 6, 2026

Uh oh!

jmank88 Oct 6, 2026

Uh oh!

bolekk left a comment

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jmank88 commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (1)

pkg/workflows/dontime.(*Store) (1)

✅ Compatible Changes (6)

pkg/settings/cresettings.Schema (1)

pkg/workflows/dontime.(*Factory) (1)

pkg/workflows/dontime/pb.(*ObservedDonTimes) (3)

pkg/workflows/dontime/pb.ObservedDonTimes (1)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmank88 Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

jmank88 Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

bolekk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jmank88 commented Sep 8, 2026 •

edited

Loading

github-actions Bot commented Sep 8, 2026 •

edited

Loading

⚠️ API Diff Results - `github.com/smartcontractkit/chainlink-common`

`pkg/workflows/dontime.(*Store)` (1)

`pkg/settings/cresettings.Schema` (1)

`pkg/workflows/dontime.(*Factory)` (1)

`pkg/workflows/dontime/pb.(*ObservedDonTimes)` (3)

`pkg/workflows/dontime/pb.ObservedDonTimes` (1)