pkg/workflows/dontime: introduce feature flagged fix for sequence number inconsistency

pkg/settings/cresettings/README.md

@@ -373,6 +373,9 @@ flowchart
 %%  the trigger coordinator's reader is likewise its own entry point
     CentralTriggerQueue.Put
 
+%% TODO placating test for now since this flowchart no longer renders
+    DonTimeSequencedTimestampsActivePeriod 
+
     classDef bound stroke:#f00
     classDef gate stroke:#0f0
     classDef queue stroke:#00f

pkg/settings/cresettings/defaults.json

@@ -59,6 +59,7 @@
 	"VaultMaxPerOracleUnexpiredBlobCumulativePayloadSizeLimit": "31.45728mb",
 	"VaultMaxPerOracleUnexpiredBlobCount": "1000",
 	"MissingRequestRecoveryEnabled": "false",
+	"DonTimeSequencedTimestampsActivePeriod": "[2100-01-01 00:00:00 +0000 UTC,2101-01-01 00:00:00 +0000 UTC]",
 	"ConfidentialCompute": {
 		"GlobalRate": "1000rps:1000",
 		"MaxRetries": "3",

pkg/settings/cresettings/defaults.toml

@@ -58,6 +58,7 @@ VaultMaxBlobPayloadSizeLimit = '25.6kb'
 VaultMaxPerOracleUnexpiredBlobCumulativePayloadSizeLimit = '31.45728mb'
 VaultMaxPerOracleUnexpiredBlobCount = '1000'
 MissingRequestRecoveryEnabled = 'false'
+DonTimeSequencedTimestampsActivePeriod = '[2100-01-01 00:00:00 +0000 UTC,2101-01-01 00:00:00 +0000 UTC]'
 
 [ConfidentialCompute]
 GlobalRate = '1000rps:1000'

pkg/settings/cresettings/settings.go

@@ -51,6 +51,12 @@ var DefaultGetter Getter
 // Deprecated: use Default
 var Config Schema
 
+var (
+	year2100                 = time.Date(2100, 1, 1, 0, 0, 0, 0, time.UTC)
+	year2101                 = time.Date(2101, 1, 1, 0, 0, 0, 0, time.UTC)
+	disabledFeatureTimeRange = TimeRange(year2100, year2101)
+)
+
 var Default = Schema{
 	WorkflowLimit:                     Int(1000),
 	WorkflowExecutionConcurrencyLimit: Int(1000),
@@ -160,6 +166,8 @@ var Default = Schema{
 	// MissingRequestRecoveryEnabled
 	MissingRequestRecoveryEnabled: Bool(false),
 
+	DonTimeSequencedTimestampsActivePeriod: disabledFeatureTimeRange,
+
 	// Confidential Compute (San Marino framework) node-level settings. Defaults
 	// mirror the previous hardcoded executor defaults so behavior is unchanged
 	// until explicitly overridden.
@@ -335,38 +343,23 @@ var Default = Schema{
 			RequestTimeout: Duration(30 * time.Second),
 		},
 
-		FeatureHTTPTriggerNewExecutionIDsActivePeriod: TimeRange(
-			time.Date(2100, 1, 1, 0, 0, 0, 0, time.UTC),
-			time.Date(2101, 1, 1, 0, 0, 0, 0, time.UTC)),
-		FeatureChainCapabilityHashBasedOCRActivePeriod: TimeRange(
-			time.Date(2100, 1, 1, 0, 0, 0, 0, time.UTC),
-			time.Date(2101, 1, 1, 0, 0, 0, 0, time.UTC)),
-		FeatureEVMWriteReportL1FeeActivePeriod: TimeRange(
-			time.Date(2100, 1, 1, 0, 0, 0, 0, time.UTC),
-			time.Date(2101, 1, 1, 0, 0, 0, 0, time.UTC)),
-		FeatureAptosWriteReportBlockTimestampActivePeriod: TimeRange(
-			time.Date(2100, 1, 1, 0, 0, 0, 0, time.UTC),
-			time.Date(2101, 1, 1, 0, 0, 0, 0, time.UTC)),
+		FeatureHTTPTriggerNewExecutionIDsActivePeriod:     disabledFeatureTimeRange,
+		FeatureChainCapabilityHashBasedOCRActivePeriod:    disabledFeatureTimeRange,
+		FeatureEVMWriteReportL1FeeActivePeriod:            disabledFeatureTimeRange,
+		FeatureAptosWriteReportBlockTimestampActivePeriod: disabledFeatureTimeRange,
 		// ON by default: covers all possible timestamps including zero time.Time{},
 		// so WorkflowTag is included in the hash matching current prod behavior.
 		// After rollout, set to far-future window to exclude WorkflowTag.
 		FeatureRequestHashIncludeWorkflowTagActivePeriod: TimeRange(
-			time.Date(1, 1, 1, 0, 0, 0, 0, time.UTC),
-			time.Date(2100, 1, 1, 0, 0, 0, 0, time.UTC)),
+			time.Date(1, 1, 1, 0, 0, 0, 0, time.UTC), year2100),
 		// OFF by default: the workflow_specs_v2.workflow_tag reconcile backfill
 		// is intentionally disabled on a fresh deploy. Ops narrows the range to
 		// cover "now" only after FeatureRequestHashIncludeWorkflowTag is muted
 		// on every DON member, so DBs can heal without producing tag-driven
 		// hash divergence during the fill window.
-		FeatureWorkflowTagBackfillActivePeriod: TimeRange(
-			time.Date(2100, 1, 1, 0, 0, 0, 0, time.UTC),
-			time.Date(2101, 1, 1, 0, 0, 0, 0, time.UTC)),
-		FeatureConsensusStricterMedianQuorumActivePeriod: TimeRange(
-			time.Date(2100, 1, 1, 0, 0, 0, 0, time.UTC),
-			time.Date(2101, 1, 1, 0, 0, 0, 0, time.UTC)),
-		FeatureConsensusIncludeAllTimestampsActivePeriod: TimeRange(
-			time.Date(2100, 1, 1, 0, 0, 0, 0, time.UTC),
-			time.Date(2101, 1, 1, 0, 0, 0, 0, time.UTC)),
+		FeatureWorkflowTagBackfillActivePeriod:           disabledFeatureTimeRange,
+		FeatureConsensusStricterMedianQuorumActivePeriod: disabledFeatureTimeRange,
+		FeatureConsensusIncludeAllTimestampsActivePeriod: disabledFeatureTimeRange,
 	},
 }
 
@@ -481,6 +474,8 @@ type Schema struct {
 
 	MissingRequestRecoveryEnabled Setting[bool]
 
+	DonTimeSequencedTimestampsActivePeriod Setting[Range[config.Timestamp]]
+
 	// Confidential Compute (San Marino framework) node-level settings.
 	ConfidentialCompute confidentialCompute
 

pkg/settings/limits/range.go

@@ -15,14 +15,14 @@ import (
 	"github.com/smartcontractkit/chainlink-common/pkg/settings"
 )
 
-// BoundLimiter is a limiter for simple bounds checks.
+// RangeLimiter is a limiter for bounded range checks.
 type RangeLimiter[N Number] interface {
 	Limiter[settings.Range[N]]
-	// Check returns ErrorBoundLimited if the value is above the limit.
+	// Check returns ErrorRangeLimited if the value is above the limit.
 	Check(context.Context, N) error
 }
 
-// NewRangeLimiter returns a RangeLimiter with the given lower bounds.
+// NewRangeLimiter returns a RangeLimiter with the given bounds.
 func NewRangeLimiter[N Number](bounds settings.Range[N]) RangeLimiter[N] {
 	return &simpleRangeLimiter[N]{bounds: bounds}
 }

pkg/workflows/dontime/factory.go

@@ -9,8 +9,11 @@ import (
 
 	"github.com/smartcontractkit/libocr/offchainreporting2plus/ocr3types"
 
+	"github.com/smartcontractkit/chainlink-common/pkg/config"
 	"github.com/smartcontractkit/chainlink-common/pkg/logger"
 	"github.com/smartcontractkit/chainlink-common/pkg/services"
+	"github.com/smartcontractkit/chainlink-common/pkg/settings/cresettings"
+	"github.com/smartcontractkit/chainlink-common/pkg/settings/limits"
 	"github.com/smartcontractkit/chainlink-common/pkg/types/core"
 	"github.com/smartcontractkit/chainlink-common/pkg/workflows/dontime/pb"
 )
@@ -26,19 +29,30 @@ const (
 var _ core.OCR3ReportingPluginFactory = &Factory{}
 
 type Factory struct {
-	store *Store
-	lggr  logger.Logger
+	store              *Store
+	lggr               logger.Logger
+	sequencedTSEnabled limits.RangeLimiter[config.Timestamp]
 
 	services.StateMachine
 }
 
 func NewFactory(s *Store, lggr logger.Logger) (*Factory, error) {
 	return &Factory{
-		store: s,
-		lggr:  logger.Named(lggr, "OCR3DonTimeFactory"),
+		store:              s,
+		lggr:               logger.Named(lggr, "OCR3DonTimeFactory"),
+		sequencedTSEnabled: limits.NewRangeLimiter(cresettings.Default.DonTimeSequencedTimestampsActivePeriod.DefaultValue),
 	}, nil
 }
 
+func (o *Factory) InitLimits(lf limits.Factory) error {
+	sequencedTSEnabled, err := limits.MakeRangeLimiter[config.Timestamp](lf, cresettings.Default.DonTimeSequencedTimestampsActivePeriod)
+	if err != nil {
+		return err
+	}
+	o.sequencedTSEnabled = sequencedTSEnabled
+	return nil
+}
+
 func (o *Factory) NewReportingPlugin(_ context.Context, config ocr3types.ReportingPluginConfig) (ocr3types.ReportingPlugin[[]byte], ocr3types.ReportingPluginInfo, error) {
 	var configProto pb.Config
 	err := proto.Unmarshal(config.OffchainConfig, &configProto)
@@ -75,6 +89,7 @@ func (o *Factory) NewReportingPlugin(_ context.Context, config ocr3types.Reporti
 	if err != nil {
 		return nil, ocr3types.ReportingPluginInfo{}, err
 	}
+	plugin.setSequencedTSEnabled(o.sequencedTSEnabled)
 	pluginInfo := ocr3types.ReportingPluginInfo{
 		Name: "DON Time Plugin",
 		Limits: ocr3types.ReportingPluginLimits{

pkg/workflows/dontime/pb/dontime.go

@@ -0,0 +1,22 @@
+package pb
+
+// MaxSeqNum returns the max sequence number from TimestampsBySequence, or -1 if none exist.
+func (t *ObservedDonTimes) MaxSeqNum() int64 {
+	var maxSeqNum int64 = -1
+	for seqNum := range t.TimestampsBySequence {
+		if seqNum > maxSeqNum {
+			maxSeqNum = seqNum
+		}
+	}
+	return maxSeqNum
+}
+
+// EarliestTS returns the earliest timestamp value from TimestampsBySequence or nil if none exist.
+func (t *ObservedDonTimes) EarliestTS() (earliestTS *int64) {
+	for _, ts := range t.TimestampsBySequence {
+		if earliestTS == nil || ts < *earliestTS {
+			earliestTS = &ts
+		}
+	}
+	return
+}

pkg/workflows/dontime/pb/dontime.proto

@@ -10,7 +10,8 @@ message Observation {
 }
 
 message ObservedDonTimes {
-  repeated int64 timestamps = 1;
+  repeated int64 timestamps = 1 [deprecated = true];
+  map<int64, int64> timestampsBySequence = 2;
 }
 
 message Outcome {