Repository navigation
fix: translate execution-provider strings from German to English - #47
Merged
Merged
Conversation
The execution-provider feature introduced four German strings into an otherwise English UI: the accessible name and form-row label for the compute-acceleration picker in the inspector, the invalidation reason recorded when the provider changes, and the "recommended" suffix appended to a provider's label. Everything around them (the other inspector form labels, the CLI's own "[recommended]" marker) is English, so the German stood out as an inconsistency rather than a deliberate choice. Changed "Rechenbeschleunigung" to "Compute acceleration" in src/matteloop/ui/inspector.py (accessible name and form label) and in src/matteloop/core/parameters.py (the stale_category reason recorded by _reduce_execution_provider). Changed the "– empfohlen" suffix built in src/matteloop/core/execution_providers.py to "– recommended", keeping the same en-dash and spacing so provider labels read e.g. "CPU – recommended". Updated the tests that asserted on the old German text so they match the new English strings: the CLI smoke test's --providers output, the inspector test's provider-option fixtures, and the execution-provider unit tests' expected labels. Trigger: repro — running `matteloop --providers`, or opening the inspector's execution-provider row, showed "Rechenbeschleunigung" and "– empfohlen" next to English labels like "Edge treatment" and "Output FPS". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The first pass on this branch fixed four German strings but left two
more, both flagged in review as still user-visible: the "experimental"
suffix on the CoreML provider label, and the fallback notice shown
when a model can't load on the selected provider. Leaving them meant
the inspector's provider picker still mixed German and English labels
side by side ("Apple CoreML – experimentell" next to "CPU –
recommended"), and the fallback path showed a German sentence in an
otherwise English error/notice surface.
Changed the "– experimentell" suffix in
src/matteloop/core/execution_providers.py to "– experimental",
matching the en-dash and spacing of the "– recommended" suffix built
in the same function.
Changed the CPU-fallback notice in
src/matteloop/jobs/segmentation_host.py from
"{label} konnte dieses Modell nicht laden. Die Verarbeitung wird
automatisch über die CPU fortgesetzt." to
"{label} could not load this model. Processing continues on the CPU.",
keeping it as an f-string with the provider label in the same
position.
Updated the tests that asserted on the old German text:
tests/ui/test_parameter_inspector.py and
tests/core/test_execution_providers.py (the CoreML label), and
tests/jobs/models/test_session.py (the fallback notice).
Trigger: repro — selecting a BirefNet model on Apple Silicon showed
"Apple CoreML – experimentell" in the provider picker, and forcing a
model load failure on a non-default provider produced a German
fallback notice, both alongside otherwise-English UI text.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 5, 2026
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The execution-provider feature left German strings in an otherwise English
UI. All six user-visible German strings found in the feature are now
translated:
src/matteloop/ui/inspector.py—"Rechenbeschleunigung"to"Compute acceleration"(accessible name and form-row label), matching the sentence-case style of the surrounding labels ("Edge treatment", "Output FPS").src/matteloop/core/parameters.py— thestale_categoryinvalidation reason to"Compute acceleration".src/matteloop/core/execution_providers.py— the"– empfohlen"suffix to"– recommended", and the"– experimentell"suffix to"– experimental", both keeping the same en-dash and spacing (e.g."CPU – recommended","Apple CoreML – experimental").src/matteloop/jobs/segmentation_host.py— the CPU-fallback notice shown when a model fails to load on the selected provider, from German to"{label} could not load this model. Processing continues on the CPU.".Tests that asserted on the old German text were updated to match:
tests/test_app_smoke.py,tests/ui/test_parameter_inspector.py,tests/core/test_parameters.py,tests/core/test_execution_providers.py,tests/jobs/models/test_session.py.A repo-wide grep for the German fragments (
Rechenbeschleunigung,empfohlen,experimentell,konnte,fortgesetzt,über die) and forstray umlauts/ß in
src//tests/.pyfiles turns up nothing left inuser-visible strings (the two remaining umlaut hits are Unicode-path test
fixtures, unrelated to this feature).
Test plan
uv run ruff check .uv run mypy srcQT_QPA_PLATFORM=offscreen uv run pytest -q(all passing)uv run python scripts/check_guardrails.pygrep -rniE "Rechenbeschleunigung|empfohlen|experimentell|konnte|fortgesetzt|über die" .returns no hits🤖 Generated with Claude Code