Skip to content

Export AWS_ENDPOINT_URL as http://localhost:<port> - #1

Merged
drk1rd merged 1 commit into
mainfrom
localhost-endpoint
Oct 14, 2026
Merged

drk1rd merged 1 commit into
mainfrom
localhost-endpoint

Conversation

@drk1rd

@drk1rd drk1rd commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

The action exported http://127.0.0.1:. S3 Control, which the Terraform AWS provider calls for every aws_s3_bucket (6.x reads bucket tags that way), puts the account ID in front of the endpoint's host: 123456789012.127.0.0.1 does not resolve, 123456789012.localhost does. The server still listens on 127.0.0.1 and the health check calls it there.

Same change as the mirror in solinode/homecloud integrations/github-action, matching homecloud aws-env, which now prints localhost for a local server.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the documented and exported AWS endpoint to use localhost, allowing account-prefixed S3 Control hostnames to resolve correctly. The health check continues to use 127.0.0.1.

S3 Control, which the Terraform AWS provider calls for every aws_s3_bucket,
puts the account ID in front of the endpoint's host. 123456789012.127.0.0.1
does not resolve; 123456789012.localhost does. This matches homecloud
aws-env, which now prints localhost for a local server.
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7b44bc95-a814-4a02-8efe-1285478fa0f0
📥 Commits

Reviewing files that changed from the base of the PR and between 7e24e4e and 7c02bef.

📒 Files selected for processing: 2
  • README.md
  • setup.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The exported AWS endpoint changes from 127.0.0.1 to localhost. The health check continues to use 127.0.0.1. The README explains how the hostname change supports account-prefixed S3 Control hostnames.

Changes: Endpoint hostname

Layer / File(s) Summary
AWS endpoint hostname
setup.sh, README.md
The setup script uses localhost for the exported AWS endpoint and retains 127.0.0.1 for the health check. The README documents that S3 Control account-prefixed hostnames resolve with localhost, unlike the numeric loopback address.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 7c02b

The hostname change supports account-prefixed S3 Control requests, and the local service remains reachable over IPv4. No actionable merge risk was identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly states the main change: exporting AWS_ENDPOINT_URL with the localhost hostname.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@drk1rd
drk1rd merged commit 2347213 into main Oct 14, 2026
2 checks passed
@drk1rd
drk1rd deleted the localhost-endpoint branch October 14, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant