Repository navigation
Export AWS_ENDPOINT_URL as http://localhost:<port> - #1
Conversation
S3 Control, which the Terraform AWS provider calls for every aws_s3_bucket, puts the account ID in front of the endpoint's host. 123456789012.127.0.0.1 does not resolve; 123456789012.localhost does. This matches homecloud aws-env, which now prints localhost for a local server.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
The action exported http://127.0.0.1:. S3 Control, which the Terraform AWS provider calls for every aws_s3_bucket (6.x reads bucket tags that way), puts the account ID in front of the endpoint's host: 123456789012.127.0.0.1 does not resolve, 123456789012.localhost does. The server still listens on 127.0.0.1 and the health check calls it there.
Same change as the mirror in solinode/homecloud integrations/github-action, matching homecloud aws-env, which now prints localhost for a local server.
Summary by CodeRabbit
localhost, allowing account-prefixed S3 Control hostnames to resolve correctly. The health check continues to use127.0.0.1.