fix: add android r8 rules - #139
Merged
Merged
Conversation
ovitrif
marked this pull request as draft
August 26, 2026 14:36
Collaborator
Author
|
version bump won't work until this PR is merged and bindings are rebuilt: |
ovitrif
force-pushed
the
feat/r8-compat
branch
from
August 26, 2026 14:49
161fc82 to
a19ce2a
Compare
This was referenced Aug 26, 2026
Package targeted UniFFI/JNA keep rules in the AAR so consuming apps can enable R8 full mode without extra rules for this library.
ovitrif
force-pushed
the
feat/r8-compat
branch
from
August 26, 2026 17:05
a19ce2a to
ffb061e
Compare
ovitrif
marked this pull request as ready for review
August 26, 2026 17:05
Collaborator
Author
|
@ben-kaufman or @coreyphillips pls do a review even though it's merged, my AI was feeling too lucky today |
ben-kaufman
reviewed
Aug 26, 2026
Collaborator
|
The 0.5.9 release symbols no longer match the published Android AAR. The manual run published the immutable Maven package, then the release run rebuilt and replaced |
This was referenced Aug 26, 2026
Collaborator
Author
|
Addressed the review concerns in: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140
The Android AAR now ships targeted R8 consumer keep rules for the UniFFI/JNA FFI surface.
This is rebased on master after #138, at
0.5.9.Description
bindings/android/lib/consumer-rules.prointo the AAR asproguard.txt.Structurefields and constructors,Callbackmethods, andUniffiLib/IntegrityCheckingUniffiLibnative method names incom.synonym.bitkitcore.bundleReleaseAarwhen those consumer keep rules are missing or empty.0.5.9.Preview
N/A — Android library packaging only.
QA Notes
Local verification:
./gradlew :lib:validateConsumerKeepRules :lib:bundleReleaseAarfrombindings/android, then confirmedproguard.txtinside the release AAR.