Repository navigation
XXE in LxmlEventHandler.parse() - #1228
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1228 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 117 117
Lines 9411 9412 +1
Branches 1446 1446
=======================================
+ Hits 9409 9410 +1
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
tefra
reviewed
Sep 8, 2026
tefra
left a comment
tefra
left a comment
Owner
There was a problem hiding this comment.
Can you update the tests please 🙏
Contributor
Author
If you have a suggestion what to update... |
As stated in tefra#1212 there is a XXE possibility for untrusted sources. This pull request makes resolving external entities configurable and disabled by default.
tefra
force-pushed
the
sec_external_entities
branch
2 times, most recently
from
October 16, 2026 08:14
2307e6b to
defb492
Compare
tefra
approved these changes
Oct 16, 2026
|
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in #1212 there is a XXE possibility for untrusted sources. This pull request makes resolving external entities configurable and disabled by default.
📒 Description
Makes resolve external reference in lxml in optional.
Resolves #1212
🔗 What I've Done
Add a configuration option.
💬 Comments
🛫 Checklist