Repository navigation
Read the Node version from the synced UI's package.json - #344
Open
rossnelson wants to merge 1 commit into
Open
rossnelson wants to merge 1 commit into
rossnelson wants to merge 1 commit into
Conversation
The UI is moving its Node pin to engines.node in package.json and dropping .node-version. pnpm already comes from the same file.
laurakwhit
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
setup-nodenow reads Node fromui-release/package.json(engines.node), notui-release/.node-version. pnpm already comes from the same file (packageManager).Why
temporalio/ui is moving to
engines.node: "^22.23.4"as its single Node source and deleting.node-version. Without this change, the first ui commit without.node-versionbreaks the sync.actions/setup-noderesolves the range to the newest matching 22.x.Merge order
Merge this, then the ui PR right after. ui
mainstill hasengines.node: ">=22.23.4", so between the two merges this action would install the newest Node major. Merging in the other order breaks the sync until this lands.