Repository navigation
Conversation
This was referenced Oct 19, 2026
tee8z
added this pull request to stack #22
October 19, 2026 20:56
tee8z
force-pushed
the
dev-2884-remote-session-commands
branch
from
October 19, 2026 23:28
aaebf65 to
a154b26
Compare
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
tee8z
force-pushed
the
dev-2884-remote-session-commands
branch
from
October 20, 2026 14:53
a154b26 to
c18f4e7
Compare
tee8z
removed this pull request from stack #22
October 20, 2026 14:56
tee8z
added this pull request to stack #26
October 20, 2026 14:56
tee8z
force-pushed
the
dev-2884-remote-session-commands
branch
from
October 20, 2026 15:01
c18f4e7 to
0a2bf27
Compare
Collaborator
Author
|
@coderabbitai full review Please review the current revision against this PR’s immediate stack base. The descriptions document the remote-agent scope, regression coverage, and outstanding runtime validation. |
|
tee8z
force-pushed
the
dev-2884-remote-session-commands
branch
2 times, most recently
from
October 20, 2026 16:24
5f59e7e to
f4bd7e5
Compare
tee8z
removed this pull request from stack #26
October 20, 2026 16:24
tee8z
added this pull request to stack #28
October 20, 2026 16:25
tee8z
force-pushed
the
dev-2884-remote-session-commands
branch
from
October 20, 2026 16:51
f4bd7e5 to
a30d073
Compare
…ssions Add the backend half of explicit thread-session lifecycle control for thread-sandbox providers. Providers may advertise `ops` in `info`; `provider_stop` sends the secret-bearing `stop` request only after the same staged bytes negotiated protocol v1 and advertised `stop`. New commands `end_remote_agent_session`, `recover_remote_agent_session` and `remote_agent_session_supports_lifecycle` share the deploy path's per-agent lock, post-lock payload rebuild, tenant scope assertion, and session binding. The recovery mode rides one invocation's provider config and is never persisted on the agent record. Expose typed TypeScript bindings for the three commands. Signed-off-by: Tee8z <tee8z@protonmail.com>
tee8z
removed this pull request from stack #28
October 20, 2026 17:22
tee8z
force-pushed
the
dev-2884-remote-session-commands
branch
from
October 20, 2026 17:22
a30d073 to
85a9520
Compare
tee8z
added this pull request to stack #30
October 20, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop cannot end a thread-sandbox session or recover one that ended. This PR adds three Tauri commands and their TypeScript bindings in
desktop/src/shared/api/tauriManagedAgents.ts. A provider advertisesstopin a new optionalinfo.opsarray. The desktop sends the secret-bearingstoprequest only after the same staged binary advertisedstop. The recovery mode goes into the provider config for one invocation and is never saved on the agent record.sequenceDiagram participant D as Desktop frontend participant T as Tauri command participant P as Provider binary (staged copy) D->>T: remote_agent_session_supports_lifecycle alt provider agent with a thread sandbox T->>P: info P-->>T: ops T-->>D: whether ops contain stop else local agent or no thread sandbox T-->>D: false end D->>T: end_remote_agent_session or recover_remote_agent_session Note over T: Per-agent lock, payload rebuilt from the record, tenant scope asserted, thread session bound alt end_remote_agent_session on a thread sandbox T->>P: info P-->>T: ops alt ops contain stop T->>P: stop (agent, provider_config) P-->>T: state ending, ended, or absent else ops do not contain stop T-->>D: error, stop is not sent end else recover_remote_agent_session T->>P: info T->>P: deploy, provider_config.sandbox.recovery.mode = checkpoint or fresh P-->>T: agent_id T-->>D: updated ManagedAgent endmanaged_agents/backend.rs:advertised_opsaccepts at most 32 non-empty strings. A provider withoutopsgets["info", "deploy"]. Astopresponse must reportending,ended, orabsent.commands/agents/provider_deploy.rs:deploy_to_providernow useslock_provider_operationsandprepare_provider_invocation, whichend_remote_agent_sessionalso uses.bind_sandbox_scoperefuses a recovery mode when the record has no thread sandbox.commands/agents/remote_session.rs: the three commands, registered inlib.rs.Delivery scope
This PR supplies the native commands and capability negotiation used by explicit remote-session end and recovery. Shared invocation helpers preserve the existing deployment lock and tenant checks for those operations. Broader client architecture changes and GPUI integration are deferred.
The provider starts advertising
info.opsin this layer, alongside the compatible desktop reader. Rollout order: ship this desktop reader before upgrading any separately installed provider that advertisesops. Earlier layers keep the legacyinfoshape.Stack
Position 15 of 23. Base: #2. Next: #3. Each PR contains one signed commit. #27 fixes the existing message-edit CI failure, and #29 fixes transient provider launch conflicts. #24 and #25 repair fork CI and security prerequisites; the feature layers remain scoped to remote agents.
Validation
mesh-llm. The integrated desktop native suite passed 3,445 tests, and 30 parallel provider-test repetitions passed. The final frontend and static checks passed on the published revision. Full localjust cihas not passed as one run: two unchanged mobile tests timed out in the full suite and passed in isolation; all 27 terminal unit tests passed in an isolated Linux container that supplies the standard tools missing from the Nix host. Updated GitHub checks are pending.Limits
Native IPC, the staged provider binary, and the real desktop flow require runtime acceptance. Automated TypeScript tests do not establish that acceptance.
Human workflow confirmation is still required by AGENTS.md before readiness. Human acceptance has not been confirmed.