Repository navigation
Conversation
tee8z
added this pull request to stack #5
October 9, 2026 17:30
tee8z
force-pushed
the
dev-2884-agent-turn-checkpoints
branch
from
October 19, 2026 15:09
f2ed1c9 to
6fb2cd2
Compare
tee8z
force-pushed
the
dev-2884-agent-turn-checkpoints
branch
from
October 19, 2026 17:36
6fb2cd2 to
2e95424
Compare
tee8z
force-pushed
the
dev-2884-agent-turn-checkpoints
branch
from
October 19, 2026 20:52
2e95424 to
936a933
Compare
tee8z
removed this pull request from stack #5
October 19, 2026 20:53
tee8z
added this pull request to stack #22
October 19, 2026 20:56
A node lost without warning sends no SIGTERM, so the checkpoint on stop never runs. The harness now also saves in the background after completed turns (one at a time, at most once per BUZZ_ACP_CHECKPOINT_AFTER_TURN_SECS, default 600), and the save on stop waits for or cancels a running one. A cancelled or failed save kills its helper's whole process group. When a Pod left no termination receipt, the reaper records the newest checkpoint directly under the session's own prefix instead of `missing`. turn_completed activity records now carry duration_ms for long-turn alerts. Signed-off-by: Tee8z <tee8z@protonmail.com>
tee8z
force-pushed
the
dev-2884-agent-turn-checkpoints
branch
from
October 19, 2026 23:28
936a933 to
a153820
Compare
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Spot node lost without warning sends no SIGTERM, so the harness never runs its save on stop. The session then ends with
checkpoint=missing, and the thread's work is gone. With this PR, the harness also saves a checkpoint in the background after completed turns. When a lost Pod left no termination receipt, the reaper uses the newest checkpoint in the session's own S3 (Amazon Simple Storage Service) prefix.buzz-acp/src/checkpoint.rs:TurnCheckpointsruns one save at a time and starts at most one perBUZZ_ACP_CHECKPOINT_AFTER_TURN_SECS(default 600, 0 disables). It runs only withBUZZ_ACP_CHECKPOINT_ON_STOP.turn_completedobserver events and activity records now carryduration_ms.buzz-sandbox-reaper: the newEvidence::Listed(key)applies only to a Sandbox that got past binding and has no receipt. ACompletedsession withListedevidence still waits out the 24h hold.docs/remote-agents.md).Stack
Position 19 of 20 in the DEV-2884 Buzz stack. Base: #4. Next: #7.
Validation
Run in a detached worktree at this commit (
CARGO_TARGET_DIRshared,CARGO_BUILD_JOBS=4):cargo test -p buzz-acp -p buzz-sandbox-reaper: 1,131 passed, 0 failed, 3 ignored. This includes the newTurnCheckpoints,evidence::latest, anda_lost_session_records_its_newest_turn_checkpointtests.cargo clippy -p buzz-acp -p buzz-sandbox-reaper --all-targets -- -D warnings: pass.Limits