Repository navigation
test(cli): cover the picker's failed listings, Esc, and signals - #57
Merged
thebrandonlucas merged 1 commit intoOct 20, 2026
Merged
Conversation
Each listing or exchange that fails during a pick now has a test: the organization listing, the organization token exchange, the environment listing, and the wallet listing. Each ends the command with its own error (exit 3), never the missing-scope error, with no "Next time" hint and the terminal modes restored. Two --env values exit 2 before any listing. Esc at the organization or environment picker keeps the missing-scope error, and its hint still names the organization picked first. A real SIGINT while the picker is open exits 130, and the PickerScreen guard restores bracketed paste and the cursor; on_a_terminal sends SIGINT for a step with no keys.
thebrandonlucas
added this pull request to stack #58
October 20, 2026 11:59
This was referenced Oct 20, 2026
tee8z
approved these changes
Oct 20, 2026
thebrandonlucas
added
the
human review wanted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: master ← #20 ← #22 ← #57 ← #24 ← #19 ← #26 ← #27 ← #28 ← #29 ← #30 ← #55. Rebased onto master (#53, #56) on 2026-10-19.
Tests for the picker paths in #22 that had none. They are split from #22 to keep that PR under 1,000 changed lines. Test-only.
invalid_grant)--envvalues--org is requiredPickerScreenwrites\x1b[?2004l\x1b[?25hand terminal modes are restoredA failed pick never falls back to the missing-scope error and never prints the "Next time" hint.
on_a_terminalnow sends SIGINT for a step with no keys; its signature is unchanged. With thePickerScreenguard removed, the SIGINT test fails.Checks
On
f266c25:cargo fmt --check,cargo clippy --locked --all-targets -- -D warnings,cargo machete --with-metadata: pass.cargo test --locked: 93 unit and 69 integration tests pass.VOLTAGE_BLESS=1 cargo test --lockedleaves the tree clean.python3 scripts/check-coverage.py: pass.scripts/crap-report.sh): no function at or above 20. Highest isapi::wait_for_paymentat 19.66, unchanged from or lower than master (19.66).voltage-pr-reviewand thevoltage-backend-engineeringRust checklist, against the stack base. Findings are fixed in this commit.Not run: the staging and live tutorials, which need credentials.