Skip to content

fix: separate benchmark smoke and rerun concurrency - #1164

Merged
yakew7 merged 2 commits into
yakew7:mainfrom
dxnnystyles:fix/issue-1147-benchmark-concurrency
Oct 25, 2026
Merged

yakew7 merged 2 commits into
yakew7:mainfrom
dxnnystyles:fix/issue-1147-benchmark-concurrency

Conversation

@dxnnystyles

Copy link
Copy Markdown
Contributor

Summary

keeps full benchmark reruns from canceling smoke checks by giving smoke, full rerun, and unrelated label events separate concurrency groups. the groups remain isolated per pull request.

Type

  • Audit
  • Explainer
  • Bug fix
  • Other

How I Tested

  • python -m pytest tests/test_workflow_concurrency.py -q (1 passed).
  • parsed all 12 workflow YAML files with PyYAML.
  • ruff check tests/test_workflow_concurrency.py and git diff --check passed.
  • this validates the workflow configuration, not scheduling on GitHub Actions.
  • confirmed the regression test fails against the original workflow because its concurrency group has no event-class suffix.

Linked issue

Closes #1147

@vercel

vercel Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

@dxnnystyles is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

@yakew7 @ahmdkaml - new PR touching a path you own, please review.

@yakew7
yakew7 merged commit e634435 into yakew7:main Oct 25, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The benchmark-diff concurrency group cancels the smoke run when the label is added

2 participants